Date: Mon, 19 Apr 2004 04:46:04 -0700 (PDT) From: Scott Lipcon <slipcon@mercea.net> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/65761: bsd.java.mk incompatibility with old make Message-ID: <200404191146.i3JBk456080543@www.freebsd.org> Resent-Message-ID: <200404191150.i3JBoBfp013648@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 65761
>Category: misc
>Synopsis: bsd.java.mk incompatibility with old make
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 19 04:50:10 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator: Scott Lipcon
>Release: 4.8
>Organization:
>Environment:
FreeBSD mercea.mercea.net 4.8-STABLE FreeBSD 4.8-STABLE #1: Tue Apr 15 20:32:03 EDT 2003 slipcon@mercea.mercea.net:/usr/obj/usr/src/sys/MERCEA i386
>Description:
make describe fails in /usr/ports/archivers/jzip.org (which is the first to use java.mk) due to the last change to bsd.java.mk:
mercea# make describe
"/usr/ports/Mk/bsd.java.mk", line 180: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.java.mk", line 180: Malformed conditional ((${OSVERSION} >= 500000))
"/usr/ports/Mk/bsd.java.mk", line 180: Missing dependency operator
"/usr/ports/Mk/bsd.java.mk", line 182: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.java.mk", line 182: Malformed conditional ((${OSVERSION} >= 400000))
"/usr/ports/Mk/bsd.java.mk", line 182: Missing dependency operator
"/usr/ports/Mk/bsd.port.mk", line 1182: if-less endif
"/usr/ports/Mk/bsd.port.mk", line 1182: Need an operator
make: fatal errors encountered -- cannot continue
>How-To-Repeat:
cd /usr/ports/archives/jzip.org
make describe
with an old version of make
>Fix:
a space needs to be added to the conditional which changed in the last update to bsd.java.mk it needs to be:
. if (${OSVERSION} >= 500000 )
on line 180 and
. elif (${OSVERSION} >= 400000 )
on line 182.
(notice the space after the 502102 and the right paren - without the space it treats it as a string "502102)" and > is invalid for strings, and then it doesn't find the right paren to end the conditional.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404191146.i3JBk456080543>