Date: Fri, 04 Oct 2024 05:34:41 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> In-Reply-To: <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-10-02T09:21:13.000+02:00, Pietro Cerutti <gahr@FreeBSD.org> wrote= : >=C2=A0On=C2=A0Oct=C2=A001=C2=A02024,=C2=A017:04=C2=A0+0000,=C2= =A0Daniel=C2=A0Engberg=C2=A0<daniel.engberg.lists@pyret.net>=C2=A0wrote: = >>=C2=A0=C2=A0Please=C2=A0review=C2=A0Porters=C2=A0Handbook,=C2=A0there= =C2=A0are=C2=A0several=C2=A0"guidelines"=C2=A0to >>=C2=A0=C2=A0make >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0the=C2=A0tree=C2=A0more=C2=A0consistent=C2= =A0and=C2=A0reducing=C2=A0overall=C2=A0workload. >=C2=A0 >=C2=A0I=C2= =A0have=C2=A0pushed=C2=A0a=C2=A0few=C2=A0cleanups=C2=A0in >=C2=A0771ce859= 9db53660f3aa7c1e31dba1c87852586c. Thanks! >>>=C2=A0=C2=A0=C2= =A0PORTVERSION=C2=A0-->=C2=A0DISTVERSION >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master= _sites-github >>=C2=A0=C2=A0 >>=C2=A0=C2=A0...and=C2=A0stray(?)=C2= =A0comment? >=C2=A0 >=C2=A0Thanks,=C2=A0corrected. >=C2=A0 >>=C2= =A0=C2=A0Correct=C2=A0maintainer?=C2=A0There's=C2=A0no=C2=A0reference=C2= =A0and=C2=A0from=C2=A0what=C2=A0I=C2=A0can=C2=A0tell >>=C2=A0=C2=A0no >= >=C2=A0=C2=A0 >>=C2=A0=C2=A0submitted=C2=A0PR=C2=A0in=C2=A0Bugzilla. >= =C2=A0 >=C2=A0The=C2=A0maintainer=C2=A0is=C2=A0correct.=C2=A0It's=C2= =A0a=C2=A0person=C2=A0I=C2=A0know=C2=A0and=C2=A0the=C2=A0port=C2=A0was= =C2=A0 >=C2=A0 >=C2=A0submitted=C2=A0to=C2=A0me=C2=A0privately.=C2= =A0I=C2=A0didn't=C2=A0think=C2=A0anyone=C2=A0would=C2=A0want=C2=A0it=C2= =A0 >=C2=A0 >=C2=A0publicized=C2=A0it=C2=A0in=C2=A0the=C2=A0commit= =C2=A0message. Just add something like "submitted via private email" o= r something similar so it's clear of origin >>=C2=A0=C2=A0libxml2= =C2=A0dependency=C2=A0should=C2=A0use=C2=A0the=C2=A0GNOME=C2=A0helper >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebsd.org/en/books/porters-hand= book/book/#using-gnome >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebs= d.org/en/books/porters-handbook/book/#gnome-components >>=C2=A0=C2=A0 >= >=C2=A0=C2=A0sqlite3=C2=A0dependency=C2=A0should=C2=A0also=C2=A0use=C2= =A0a=C2=A0helper >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebsd.org/= en/books/porters-handbook/book/#using-databases-uses >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0CMAKE_ARGS=C2=A0can=C2=A0be=C2=A0replaced=C2=A0with=C2=A0CMAKE_= OFF=3D=C2=A0ENABLE_PYTHON >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.fre= ebsd.org/en/books/porters-handbook/book/#using-cmake >=C2=A0 >=C2=A0Tha= nks,=C2=A0corrected. >=C2=A0 >>=C2=A0=C2=A0do-test=C2=A0section=C2= =A0can=C2=A0be=C2=A0replaced=C2=A0with=C2=A0USES=3D=C2=A0cmake:testing >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0https://cgit.freebsd.org/ports/tree/Mk/Uses/cm= ake.mk#n20 >=C2=A0 >=C2=A0I=C2=A0wasn't=C2=A0able=C2=A0to=C2=A0do=C2= =A0it=C2=A0with=C2=A0cmake:testing.=C2=A0Were=C2=A0you? Upstream uses = from what I can tell an rather old approach for test target, https:/= /github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt= #L160 The "EXCLUDE FROM ALL" part is what causes the issue >>= =C2=A0=C2=A0Poudriere=C2=A0also=C2=A0lists=C2=A0quite=C2=A0a=C2=A0few=C2= =A0warnings=C2=A0about=C2=A0dependencies=C2=A0and >>=C2=A0=C2=A0the >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0REINPLACE_CMD=C2=A0commands.=C2=A0 >>=C2= =A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0https://pdr2.bofh.network/data/141-diizzy/= 2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log >=C2=A0 >=C2=A0Nice.= =C2=A0I=C2=A0wasn't=C2=A0aware=C2=A0of=C2=A0poudriere's=C2=A0Q/A=C2=A0phase= .=C2=A0I=C2=A0used=C2=A0poudriere=C2=A0bulk >=C2=A0to=C2=A0 >=C2=A0 >= =C2=A0test=C2=A0the=C2=A0port=C2=A0but=C2=A0I=C2=A0don't=C2=A0see=C2=A0that= =C2=A0in=C2=A0my=C2=A0logs.=C2=A0How=C2=A0do=C2=A0I=C2=A0enable=C2=A0it? = >=C2=A0 >=C2=A0https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01= _12h26m54s/logs/createrepo_c-1.1.4.log >=C2=A0 >=C2=A0Also,=C2=A0I= =C2=A0have=C2=A0run=C2=A0`portlint=C2=A0-AC`=C2=A0multiple=C2=A0times=C2= =A0as=C2=A0I=C2=A0was=C2=A0reviewing >=C2=A0the=C2=A0 >=C2=A0 >=C2= =A0port,=C2=A0and=C2=A0it=C2=A0was=C2=A0happy=C2=A0with=C2=A0what=C2=A0I= =C2=A0had. >=C2=A0 >=C2=A0Yeah,=C2=A0I=C2=A0should=C2=A0skim=C2=A0throu= gh=C2=A0the=C2=A0handbook=C2=A0once=C2=A0in=C2=A0a=C2=A0while.=C2=A0I've= =C2=A0been=C2=A0 >=C2=A0 >=C2=A0doing=C2=A0ports=C2=A0for=C2=A0a=C2= =A0long=C2=A0time=C2=A0and=C2=A0I=C2=A0am=C2=A0probably=C2=A0missing=C2= =A0out=C2=A0on=C2=A0the >=C2=A0latest=C2=A0 >=C2=A0 >=C2=A0enhancemen= ts=C2=A0and=C2=A0developments. >=C2=A0 >>=C2=A0=C2=A0It=C2=A0also=C2= =A0seems=C2=A0to=C2=A0look=C2=A0for=C2=A0Doxygen=C2=A0by=C2=A0default >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0which=C2=A0you=C2=A0probably=C2=A0want=C2= =A0to=C2=A0disable=C2=A0to=C2=A0avoid=C2=A0potential=C2=A0plist >>=C2= =A0=C2=A0issues. >=C2=A0 >=C2=A0Well,=C2=A0they=C2=A0don't=C2=A0provide= =C2=A0a=C2=A0way=C2=A0to=C2=A0turn=C2=A0off=C2=A0docs,=C2=A0but=C2=A0I= =C2=A0don't=C2=A0see=C2=A0an=C2=A0 >=C2=A0 >=C2=A0issue=C2=A0with=C2= =A0it=C2=A0building=C2=A0docs=C2=A0if=C2=A0it=C2=A0finds=C2=A0doxygen.= =C2=A0We=C2=A0won't=C2=A0be >=C2=A0installing=C2=A0 >=C2=A0 >=C2= =A0them=C2=A0anyway. https://cmake.org/cmake/help/latest/variable/CMAK= E_DISABLE_FIND_PACKAGE_PackageName.html works :-) >=C2=A0--=C2=A0 = >=C2=A0 >=C2=A0Pietro=C2=A0Cerutti >=C2=A0 >=C2=A0I=C2=A0have=C2= =A0pledged=C2=A0to=C2=A0give=C2=A010%=C2=A0of=C2=A0income=C2=A0to=C2=A0effe= ctive=C2=A0charities >=C2=A0 >=C2=A0and=C2=A0invite=C2=A0you=C2=A0to= =C2=A0join=C2=A0me=C2=A0-=C2=A0https://givingwhatwecan.org I've hacked= together a patch doing the final cleanups which fixes the Q/A issues. = I've also left a comment in one of the submitted PRs as it breaks buil= d if optional dependencies are disabled. https://pdr2.bofh.network/dat= a/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log (testport)= https://pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/c= reaterepo_c-1.1.4.log (bulk) Not sure why your Podriere doesn't run = QA on bulk builds :-/ Patch: https://projects.pyret.net/files/fre= ebsd-patches/createrepo_c-improve.patch Best regards, Daniel = --_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div style=3D"font-family: 'Helvetica Neue', Helvetica, Arial, = sans-serif; font-size: 14px">On 2024-10-02T09:21:13.000+02:00, Pietro Cerut= ti <gahr@FreeBSD.org> wrote:<br></div><div class=3D"ik_mail_quote ans= werContentMessage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-sp= ace: normal;"><div>On Oct 01 2024, 17:04 +0000, Daniel Engberg <<a class= =3D"defaultMailLink" href=3D"mailto:daniel.engberg.lists@pyret.net">daniel.= engberg.lists@pyret.net</a>> wrote:<br></div><blockquote class=3D"ws-ng-= quote"><div> Please review Porters Handbook, there are several "guidelines"= to make<br></div><div>the tree more consistent and reducing overall worklo= ad.<br></div></blockquote><div> <br></div><div>I have pushed a few cleanups= in 771ce8599db53660f3aa7c1e31dba1c87852586c.<br></div></pre></blockquote><= /div><div style=3D"font-family: 'Helvetica Neue', Helvetica, Arial, sans-se= rif; font-size: 14px">Thanks!<br></div><div class=3D"ik_mail_quote answerCo= ntentMessage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: = normal;"><div><br></div><div><br></div><blockquote class=3D"ws-ng-quote"><d= iv> <br></div><blockquote class=3D"ws-ng-quote"> PORTVERSION --> DISTVER= SION<br></blockquote><div> <br></div><div><a data-ik=3D"ik-secure" rel=3D"n= oopener noreferrer" class=3D"defaultMailLink" href=3D"https://docs.freebsd.= org/en/books/porters-handbook/book/#makefile-master_sites-github" target=3D= "_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-= master_sites-github</a><br></div><div><br></div><div>...and stray(?) commen= t?<br></div></blockquote><div> <br></div><div>Thanks, corrected.<br></div><= div><br></div><blockquote class=3D"ws-ng-quote"><div> Correct maintainer? T= here's no reference and from what I can tell no<br></div><div>submitted PR = in Bugzilla.<br></div></blockquote><div> <br></div><div>The maintainer is c= orrect. It's a person I know and the port was <br></div><div>submitted to m= e privately. I didn't think anyone would want it <br></div><div>publicized = it in the commit message.<br></div></pre></blockquote></div><div style=3D"f= ont-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px= ">Just add something like "submitted via private email" or something simila= r so it's clear of origin<br></div><div class=3D"ik_mail_quote answerConten= tMessage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: norm= al;"><div><br></div><div><br></div><blockquote class=3D"ws-ng-quote"><div> = libxml2 dependency should use the GNOME helper<br></div><div><br></div><div= ><a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailL= ink" href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#using= -gnome" target=3D"_blank">https://docs.freebsd.org/en/books/porters-handboo= k/book/#using-gnome</a><br></div><div><br></div><div><a data-ik=3D"ik-secur= e" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"https://do= cs.freebsd.org/en/books/porters-handbook/book/#gnome-components" target=3D"= _blank">https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-comp= onents</a><br></div><div><br></div><div>sqlite3 dependency should also use = a helper<br></div><div><br></div><div><a data-ik=3D"ik-secure" rel=3D"noope= ner noreferrer" class=3D"defaultMailLink" href=3D"https://docs.freebsd.org/= en/books/porters-handbook/book/#using-databases-uses" target=3D"_blank">htt= ps://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses<= /a><br></div><div><br></div><div>CMAKE_ARGS can be replaced with CMAKE_OFF= =3D ENABLE_PYTHON<br></div><div><br></div><div><a data-ik=3D"ik-secure" rel= =3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"https://docs.fre= ebsd.org/en/books/porters-handbook/book/#using-cmake" target=3D"_blank">htt= ps://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake</a><br></= div></blockquote><div> <br></div><div>Thanks, corrected.<br></div><div><br>= </div><blockquote class=3D"ws-ng-quote"><div> do-test section can be replac= ed with USES=3D cmake:testing<br></div><div><br></div><div><a data-ik=3D"ik= -secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"http= s://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20" target=3D"_blank">htt= ps://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20</a><br></div></blockq= uote><div> <br></div><div>I wasn't able to do it with cmake:testing. Were y= ou?<br></div></pre></blockquote></div><div style=3D"font-family: 'Helvetica= Neue', Helvetica, Arial, sans-serif; font-size: 14px">Upstream uses from w= hat I can tell an rather old approach for test target,<br></div><div style= =3D"font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size:= 14px"><a href=3D"https://github.com/rpm-software-management/createrepo_c/b= lob/master/CMakeLists.txt#L160">https://github.com/rpm-software-management/= createrepo_c/blob/master/CMakeLists.txt#L160</a><br></div><div style=3D"fon= t-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">= The "EXCLUDE FROM ALL" part is what causes the issue<br></div><div class=3D= "ik_mail_quote answerContentMessage"><blockquote class=3D"ws-ng-quote"><pre= style=3D"white-space: normal;"><div style=3D"font-family: 'Helvetica Neue'= , Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div><br></div><= div><br></div><blockquote class=3D"ws-ng-quote"><div> Poudriere also lists = quite a few warnings about dependencies and the<br></div><div>REINPLACE_CMD= commands. <br></div><blockquote class=3D"ws-ng-quote"> <a data-ik=3D"ik-se= cure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"https:/= /pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1= .1.4.log" target=3D"_blank">https://pdr2.bofh.network/data/141-diizzy/2024-= 10-01_11h36m29s/logs/createrepo_c-1.1.4.log</a><br></blockquote></blockquot= e><div> <br></div><div>Nice. I wasn't aware of poudriere's Q/A phase. I use= d poudriere bulk to <br></div><div>test the port but I don't see that in my= logs. How do I enable it?<br></div><div><a data-ik=3D"ik-secure" rel=3D"no= opener noreferrer" class=3D"defaultMailLink" href=3D"https://gahr.ch/poudri= ere/logs/bulk/14amd64-dev/2024-10-01_12h26m54s/logs/createrepo_c-1.1.4.log"= target=3D"_blank">https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-= 01_12h26m54s/logs/createrepo_c-1.1.4.log</a><br></div><div><br></div><div>A= lso, I have run `portlint -AC` multiple times as I was reviewing the <br></= div><div>port, and it was happy with what I had.<br></div><div><br></div><d= iv>Yeah, I should skim through the handbook once in a while. I've been <br>= </div><div>doing ports for a long time and I am probably missing out on the= latest <br></div><div>enhancements and developments.<br></div><div><br></d= iv><blockquote class=3D"ws-ng-quote"><div> It also seems to look for Doxyge= n by default<br></div><div>which you probably want to disable to avoid pote= ntial plist issues.<br></div></blockquote><div> <br></div><div>Well, they d= on't provide a way to turn off docs, but I don't see an <br></div><div>issu= e with it building docs if it finds doxygen. We won't be installing <br></d= iv><div>them anyway.<br></div></pre></blockquote></div><div style=3D"font-f= amily: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a = href=3D"https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PAC= KAGE_PackageName.html">https://cmake.org/cmake/help/latest/variable/CMAKE_D= ISABLE_FIND_PACKAGE_PackageName.html</a> works :-)<br></div><div class=3D"i= k_mail_quote answerContentMessage"><blockquote class=3D"ws-ng-quote"><pre s= tyle=3D"white-space: normal;"><div><br></div><div><br></div><div>-- <br></d= iv><div>Pietro Cerutti<br></div><div>I have pledged to give 10% of income t= o effective charities<br></div><div>and invite you to join me - <a data-ik= =3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href= =3D"https://givingwhatwecan.org" target=3D"_blank">https://givingwhatwecan.= org</a><br></div></pre></blockquote></div><div style=3D"font-family: 'Helve= tica Neue', Helvetica, Arial, sans-serif; font-size: 14px">I've hacked toge= ther a patch doing the final cleanups which fixes the Q/A issues.<br></div>= <div style=3D"font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; = font-size: 14px">I've also left a comment in one of the submitted PRs as it= breaks build if optional dependencies are disabled.<br></div><div style=3D= "font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14= px"><br></div><div style=3D"font-family: 'Helvetica Neue', Helvetica, Arial= , sans-serif; font-size: 14px"><a href=3D"https://pdr2.bofh.network/data/14= 1-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log">https://pdr2.bof= h.network/data/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log<= /a> (testport)<br></div><div style=3D"font-family: 'Helvetica Neue', Helvet= ica, Arial, sans-serif; font-size: 14px"><a href=3D"https://pdr2.bofh.netwo= rk/data/133-diizzy/2024-10-03_22h05m43s/logs/createrepo_c-1.1.4.log">https:= //pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/createrepo_c-= 1.1.4.log</a> (bulk)<br></div><div style=3D"font-family: 'Helvetica Neue', = Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style=3D"font= -family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">N= ot sure why your Podriere doesn't run QA on bulk builds :-/<br></div><div s= tyle=3D"font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-s= ize: 14px"><br></div><div style=3D"font-family: 'Helvetica Neue', Helvetica= , Arial, sans-serif; font-size: 14px">Patch:<br></div><div style=3D"font-fa= mily: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><a h= ref=3D"https://projects.pyret.net/files/freebsd-patches/createrepo_c-improv= e.patch">https://projects.pyret.net/files/freebsd-patches/createrepo_c-impr= ove.patch</a><br></div><div style=3D"font-family: 'Helvetica Neue', Helveti= ca, Arial, sans-serif; font-size: 14px"><br></div><div style=3D"font-family= : 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best reg= ards,<br></div><div style=3D"font-family: 'Helvetica Neue', Helvetica, Aria= l, sans-serif; font-size: 14px">Daniel<br></div><div style=3D"font-family: = 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div>= </body></html> --_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1c5e55cb722998c9eff8345c43853aee>