Date: Wed, 11 Mar 2015 10:47:26 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Ian Lepore <ian@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gleb Smirnoff <glebius@FreeBSD.org> Subject: Re: svn commit: r279828 - head/sys/dev/cadence Message-ID: <55000F2E.80804@selasky.org> In-Reply-To: <201503092239.t29MdxUo089384@svn.freebsd.org> References: <201503092239.t29MdxUo089384@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/09/15 23:39, Ian Lepore wrote: > - if ((ifp->if_flags & IFF_BROADCAST) == 0) > + if ((if_getflags(ifp) & IFF_BROADCAST) == 0) A comment: I think it would be better if the flags were not a bitmask, but an enum or structure, allowing for more than 32 or 64 bit-flags. if (if_getflags(ifp, broadcast) == 0) --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55000F2E.80804>