Date: Thu, 15 Dec 2011 17:57:15 +0500 From: Jan Beich <jbeich@tormail.net> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/lensfun Makefile pkg-plist Message-ID: <1RbAuc-000Mkz-3U@internal.tormail.net> In-Reply-To: <201112151145.pBFBjABj033318@repoman.freebsd.org> (Alexey Dokuchaev's message of "Thu, 15 Dec 2011 11:45:10 %2B0000 (UTC)") References: <201112151145.pBFBjABj033318@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@FreeBSD.org> writes: > FreeBSD ports repository > > Modified files: > graphics/lensfun Makefile pkg-plist > Log: > - Change license: GPL only applies to binaries, which are not installed by > the port, so use more appropriate LGPL; this also brings us in line with > most of the GNU/Linux distributions > - Remove licenses and useless documentation (README file containing build > instructions); 95% of users do not interact with lensfun directly anyway > - Adjust Python dependency: it is only required during build time > - Enable verbose build (helps to study logs) > - Respect CXX/AR[*], CFLAGS; adjust COMMENT and Makefile header Why not fix WITH_DEBUG by removing `-s' from GCC.LDFLAGS.release? pmcstat/dtrace also want unstripped binaries, e.g. set via empty STRIP in make.conf. --- graphics/lensfun/Makefile +++ graphics/lensfun/Makefile @@ -33,17 +33,23 @@ PLIST_SUB+= LIBVERSION=${LIBVERSION} +.include <bsd.port.pre.mk> + +.if defined(STRIP) && ${STRIP} != "" +LDFLAGS+= -s +.endif + post-patch: .SILENT ${REINPLACE_CMD} -e '1s|#!/usr/bin/python|#!/usr/bin/env python|' \ -e 's|make --version|g&|' -e '/DOXYGEN/d' ${WRKSRC}/configure ${REINPLACE_CMD} -e \ 's|CONF_LIBDIR)pkgconfig|CONF_LIBDIR)../libdata/pkgconfig|' \ ${WRKSRC}/build/tibs/compiler/pkgconfig.mak - ${REINPLACE_CMD} -e '/-s -O3/d' ${WRKSRC}/build/tibs/compiler/gcc.mak + ${REINPLACE_CMD} -e '/-s/d' ${WRKSRC}/build/tibs/compiler/gcc.mak ${REINPLACE_CMD} -e '/GROUPS/s| DOCS||' ${WRKSRC}/build/tibs/rules.mak post-install: ${LN} -sf lib${PORTNAME}.so \ ${PREFIX}/lib/lib${PORTNAME}.so.${LIBVERSION} -.include <bsd.port.mk> +.include <bsd.port.post.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1RbAuc-000Mkz-3U>