Date: Fri, 5 Nov 2004 11:06:09 -0800 From: Peter Wemm <peter@wemm.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_write.3 archive_write.c archive_write_set_compression_bzip2.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c archive_write_set_format_cpio.c archive_write_set_format_pax.c archive_write_set_format_shar.c archive_write_set_format_ustar.c Message-ID: <200411051106.09523.peter@wemm.org> In-Reply-To: <200411050526.iA55QUIb068633@repoman.freebsd.org> References: <200411050526.iA55QUIb068633@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This broke world for me: /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: error: conflicting types for 'archive_compressor_bzip2_write' /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: error: previous declaration of 'archive_compressor_bzip2_write' was here /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: error: conflicting types for 'archive_compressor_bzip2_write' /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: error: previous declaration of 'archive_compressor_bzip2_write' was here /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:61: warning: 'archive_compressor_bzip2_write' used but never defined /home/peter/fbp4/hammer/lib/libarchive/archive_write_set_compression_bzip2.c:163: warning: 'archive_compressor_bzip2_write' defined but not used *** Error code 1 'int' != 'ssize_t'. In the patch you changed a 'static ssize_t' to a 'static int' and didn't update the prototype. On Thursday 04 November 2004 09:26 pm, Tim Kientzle wrote: > kientzle 2004-11-05 05:26:30 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_write.3 archive_write.c > archive_write_set_compression_bzip2.c > archive_write_set_compression_gzip.c > archive_write_set_compression_none.c > archive_write_set_format_cpio.c > archive_write_set_format_pax.c > archive_write_set_format_shar.c > archive_write_set_format_ustar.c > Log: > Clean up the error handling in the > write path. In particular, this should > solve some problems people have seen with > bsdtar not exiting on various write errors. > > Revision Changes Path > 1.8 +7 -7 src/lib/libarchive/archive_write.3 > 1.13 +4 -1 src/lib/libarchive/archive_write.c > 1.6 +27 -18 > src/lib/libarchive/archive_write_set_compression_bzip2.c 1.8 > +28 -19 src/lib/libarchive/archive_write_set_compression_gzip.c > 1.6 +17 -9 > src/lib/libarchive/archive_write_set_compression_none.c 1.5 +9 > -9 src/lib/libarchive/archive_write_set_format_cpio.c 1.19 > +8 -8 src/lib/libarchive/archive_write_set_format_pax.c 1.11 > +109 -58 src/lib/libarchive/archive_write_set_format_shar.c 1.12 > +4 -4 src/lib/libarchive/archive_write_set_format_ustar.c -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411051106.09523.peter>