Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 May 2021 14:28:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        java@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 255902] java/openjdk13: Fix compile error (and possible segfaults) with clang 12
Message-ID:  <bug-255902-8522-m6arVAvtZP@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-255902-8522@https.bugs.freebsd.org/bugzilla/>
References:  <bug-255902-8522@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-java (Nobody)
<java@FreeBSD.org> for maintainer-feedback:
Bug 255902: java/openjdk13: Fix compile error (and possible segfaults) with
clang 12
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255902



--- Description ---
During an exp-run for llvm 12 (see bug 255570), it turned out that at least
openjdk11 and openjdk12 do not build with clang 12.0.0. The exp-run therefo=
re
skipped openjdk13.

Building this manually shows that it results in a compile error:

gmake[4]: Leaving directory
'/wrkdirs/share/dim/ports/java/openjdk13/work/openjdk-jdk13u-jdk-13.0.7-1-1=
/mak
e'
/wrkdirs/share/dim/ports/java/openjdk13/work/openjdk-jdk13u-jdk-13.0.7-1-1/=
src/
hotspot/cpu/x86/vm_version_ext_x86.cpp:748:3:
error: suspicious concatenation of string literals in an array initializati=
on;
did you mean to separate the elements with a comma?
[-Werror,-Wstring-concatenation]
  "",
  ^
/wrkdirs/share/dim/ports/java/openjdk13/work/openjdk-jdk13u-jdk-13.0.7-1-1/=
src/
hotspot/cpu/x86/vm_version_ext_x86.cpp:747:3:
note: place parentheses around the string literal to silence warning
  "Opteron QC/Phenom"  // Barcelona et.al.
  ^
1 error generated.

This is due to a missing backport of this commit [1]:

commit f8a9602a0a65cdc98eb940aac9529256ded2bf42
Author: Yasumasa Suenaga <ysuenaga@openjdk.org>
Date:	Thu Jan 21 06:08:13 2021 +0000

    8260025: Missing comma in VM_Version_Ext::_family_id_amd

    Reviewed-by: dholmes, stuefe

Even after applying this fix, there is still a possibility of a segfault du=
ring
the build, due to another missing backport, of this commit [2]:

commit c484d8904285652246c3af212a4211b9a8955149
Author: Thomas Stuefe <stuefe@openjdk.org>
Date:	Tue Mar 16 05:49:01 2021 +0000

    8263557: Possible NULL dereference in Arena::destruct_contents()

    Reviewed-by: kbarrett, coleenp

I have attached a patch that adds these commits as additional patches.

[1]
https://github.com/openjdk/jdk/commit/f8a9602a0a65cdc98eb940aac9529256ded2b=
f42
[2]
https://github.com/openjdk/jdk/commit/c484d8904285652246c3af212a4211b9a8955=
149



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255902-8522-m6arVAvtZP>