Date: Thu, 29 Sep 2005 10:17:13 +0300 From: Alex Lyashkov <shadow@psoft.net> To: Peter Edwards <peadar.edwards@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: biodone panics Message-ID: <1127978233.3383.12.camel@berloga.shadowland> In-Reply-To: <34cb7c8405092815247dc89bf6@mail.gmail.com> References: <34cb7c8405092815247dc89bf6@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>
> > biodone(struct bio *bp)
> > {
> > void (*done)(struct bio *);
> >
> > mtx_lock(&bdonelock);
> > bp->bio_flags |= BIO_DONE;
> > done = bp->bio_done
> > if (done == NULL)
> > wakeup(bp);
> > mtx_unlock(&bdonelock);
> > if (done != NULL)
> > bp->bio_done(bp);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
posible it should be
if(done != NULL)
done(bp);
?
> > }
>
> Anyone agree?
> _______________________________________________
--
FreeVPS Developers Team http://www.freevps.com
Positive Software http://www.psoft.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1127978233.3383.12.camel>