Date: Sat, 08 Sep 2001 16:36:18 +1000 From: Greg Black <gjb@gbch.net> To: obrien@freebsd.org Cc: Bill Swingle <unfurl@dub.net>, FreeBSD Hackers <hackers@freebsd.org> Subject: Re: tiny patch to pkg_add Message-ID: <nospam-999930978.92645@maxim.gbch.net> In-Reply-To: <20010907162242.A16949@dragon.nuxi.com> of Fri, 07 Sep 2001 16:22:43 MST References: <20010907150416.A38565@dub.net> <20010907162242.A16949@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" wrote: | On Fri, Sep 07, 2001 at 03:04:16PM -0700, Bill Swingle wrote: | > So this represents my most significant effort to date to fix something | > in C. It took me far too long to identify where the one line fix needed | > to go and even longer to figure out how to do it in C. | > | > Here's the problem that this fixes: | | This was introduced in rev 1.38: | | and replace a big if..then..else construct | to determine the package download directory with a lookup table. | | I am very tempted to back this part out. This "better implimentation" | has now had two logic bugs. I wrote that "big if..then..else contstruct" | so that the code would be *so* simple my simple my 1st quarter freshman | students (back when I TA'ed) could understand it. I did it that way | because I got tired of committers constantly breaking -r. Simple and correct is always better than clever and wrong. I'd be strongly in favour of backing it out. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?nospam-999930978.92645>