Date: Tue, 24 May 2005 15:30:11 GMT From: Joseph Scott <joseph@randomnetworks.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/81405: [update] sysutils/adtool to 1.3 Message-ID: <200505241530.j4OFUBd3074939@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/81405; it has been noted by GNATS. From: Joseph Scott <joseph@randomnetworks.com> To: Sergey Matveychuk <sem@FreeBSD.org> Cc: bug-followup@FreeBSD.org Subject: Re: ports/81405: [update] sysutils/adtool to 1.3 Date: Tue, 24 May 2005 08:23:05 -0700 On May 24, 2005, at 7:58 AM, Sergey Matveychuk wrote: > Dear maintainer! > > Take the PR into account please! It would be helpful if you simply CC'd me on the original PR, that way I'd know it was there. I don't approve of this patch. The white space changes are completely unnecessary, I'm not sure that changing HAS_CONFIGURE to GNU_CONFIGURE is correct, and you also removed the prefix setting for the build (does this tie into GNU_CONFIGURE?). I appreciate your effort here and would approve the update if the white space changes weren't included and you explained why you want to make the other changes (assuming they turn out to be correct) outside of simply updating the port. -- Joseph Scott URL: http://joseph.randomnetworks.com/ Email: joseph@randomnetworks.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505241530.j4OFUBd3074939>