Date: Tue, 13 Jan 2026 08:37:11 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests Message-ID: <CANCZdfofLubYy5%2BWonHRjBodg-u94-FGZft4k0mH6emtcW1Jzw@mail.gmail.com> In-Reply-To: <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Jan 13, 2026 at 7:56 AM John Baldwin <jhb@freebsd.org> wrote: > On 1/12/26 02:37, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb > > > > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2026-01-10 16:20:20 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2026-01-12 07:18:11 +0000 > > > > github: Add more context to pull requests > > > > Add code to fetch and decode CODEOWNERS and automatically @ people > in > > the review. > > > > Create a new file, .github/path-rules.txt that has a set of paths to > > match and specific warnings about that part of the tree. We'll use > this > > to try to wave off pull requests in certain areas of the tree, as > well > > as remind people when contrib is involved, etc. > > > > Sponsored by: Netflix > > --- > > .github/path-rules.txt | 10 ++++ > > .github/workflows/checklist.yml | 106 > ++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 106 insertions(+), 10 deletions(-) > > > > diff --git a/.github/path-rules.txt b/.github/path-rules.txt > > new file mode 100644 > > index 000000000000..297cfe8def35 > > --- /dev/null > > +++ b/.github/path-rules.txt > > @@ -0,0 +1,10 @@ > > +# > > +# Format the similar to CODEOWNERS: Each line has a path, whitespace > and a > > +# message for contributors. > > +# > > +sys/contrib/device-tree :caution: No changes should be made here > by pull request > > +# Catch all > > +contrib :warning: Contributed software usually managed by > vendor branch > > +crypto :warning: Contributed crypto software usually > managed by vendor branch > > +sys/contrib :warning: Contributed software usually managed by vendor > branch > > +sys/crypto :warning: Contributed crypto software usually managed by > vendor branch > > sys/crypto isn't really the same. We store the generated OpenSSL assembly > files there > for use by ossl(4), but most of sys/crypto is not vendored (e.g. ccp, the > non-assembly ossl > bits, aesni are all just bespoke). > That's the beauty of this: We can have whatever we want here... These were placeholders until we had more nuanced things. I see things like openssh in crypto too, so many things are vendored there, in addition to the mire of inconsistency... First one wins (or did I take that out, if I did, I should put it back).... I'd also thought this might couple well with the 3rd party audit and we could generate some json from that to give upstream pointers, project contacts, etc around all that. But maybe just :caution: Cryptographic software requires special care that the project cannot give to pull requests. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Jan 13, 2026 at 7:56 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/12/26 02:37, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=7f8b4db9e001d94974a081e5fd58c4f3994429cb</a><br>; > <br> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2026-01-10 16:20:20 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2026-01-12 07:18:11 +0000<br> > <br> > github: Add more context to pull requests<br> > <br> > Add code to fetch and decode CODEOWNERS and automatically @ people in<br> > the review.<br> > <br> > Create a new file, .github/path-rules.txt that has a set of paths to<br> > match and specific warnings about that part of the tree. We'll use this<br> > to try to wave off pull requests in certain areas of the tree, as well<br> > as remind people when contrib is involved, etc.<br> > <br> > Sponsored by: Netflix<br> > ---<br> > .github/path-rules.txt | 10 ++++<br> > .github/workflows/checklist.yml | 106 ++++++++++++++++++++++++++++++++++++----<br> > 2 files changed, 106 insertions(+), 10 deletions(-)<br> > <br> > diff --git a/.github/path-rules.txt b/.github/path-rules.txt<br> > new file mode 100644<br> > index 000000000000..297cfe8def35<br> > --- /dev/null<br> > +++ b/.github/path-rules.txt<br> > @@ -0,0 +1,10 @@<br> > +#<br> > +# Format the similar to CODEOWNERS: Each line has a path, whitespace and a<br> > +# message for contributors.<br> > +#<br> > +sys/contrib/device-tree :caution: No changes should be made here by pull request<br> > +# Catch all<br> > +contrib :warning: Contributed software usually managed by vendor branch<br> > +crypto :warning: Contributed crypto software usually managed by vendor branch<br> > +sys/contrib :warning: Contributed software usually managed by vendor branch<br> > +sys/crypto :warning: Contributed crypto software usually managed by vendor branch<br> <br> sys/crypto isn't really the same. We store the generated OpenSSL assembly files there<br> for use by ossl(4), but most of sys/crypto is not vendored (e.g. ccp, the non-assembly ossl<br> bits, aesni are all just bespoke).<br></blockquote><div><br></div><div>That's the beauty of this: We can have whatever we want here... These were placeholders until</div><div>we had more nuanced things. I see things like openssh in crypto too, so many things are</div><div>vendored there, in addition to the mire of inconsistency... First one wins (or did I take that out,</div><div>if I did, I should put it back).... I'd also thought this might couple well with the 3rd party audit</div><div>and we could generate some json from that to give upstream pointers, project contacts, etc</div><div>around all that.</div><div><br></div><div>But maybe just</div><div><br></div><div>:caution: Cryptographic software requires special care that the project cannot give to pull requests.</div><div><br></div><div>Warner</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfofLubYy5%2BWonHRjBodg-u94-FGZft4k0mH6emtcW1Jzw>