Date: Tue, 23 Apr 2024 13:44:40 -0600 From: Warner Losh <imp@bsdimp.com> To: Xin LI <delphij@gmail.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, Lexi Winter <lexi@le-fay.org>, Ed Maste <emaste@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, imp@freebsd.org Subject: Re: git: 67783db661f8 - main - CONTRIBUTING: request only one submission type per change Message-ID: <CANCZdfrdjT6D_=a2n6q3Vgq-cJqx6wVg0QTv7kgJXi9mMAa5Hg@mail.gmail.com> In-Reply-To: <CAGMYy3vN-OW%2BRwhNF7aPc=RyZxQd3=jmS8L7e9_dFHFUbGWG6g@mail.gmail.com> References: <202404181915.43IJFEoG020480@gitrepo.freebsd.org> <ZiF0PH5yWJlbaFo8@ilythia.eden.le-fay.org> <ZigFzAIs7eZQ3DMW@cell.glebi.us> <CAGMYy3vN-OW%2BRwhNF7aPc=RyZxQd3=jmS8L7e9_dFHFUbGWG6g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000009d821d0616c8c987 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We have thought about it. People are setting one (forgejo) up right now as a proof of concept. Contact me if you'd like to participate, or setup something different to evaluate (past calls for the git next generation working group didn't produce too many interested parties that could move the ball). In the long term, though, we'll have to do something like Gerrit, Gitlab, or Forgejo or similar. There's a lot of factors to consider for each of the solutions that are available, but it's hard to setup something even as a test experiment to see if it can make things better. Github pull requests are my attempt to do something to move the needle on the project being so hard to contribute to in a way that won't get ignored. There's plenty of problems with it, but we're also getting some good code and contributors from it. Nothing is stopping other attempts, other than the time and effort it takes to set them up and administer them.... Warner On Tue, Apr 23, 2024 at 1:34=E2=80=AFPM Xin LI <delphij@gmail.com> wrote: > Possibly slightly off-topic, but have we considered some other > alternatives to Phabricator, like Gerrit > <https://www.gerritcodereview.com/>? (My opinion might be biased as we > use Gerrit at $WORK). I liked the review UI more (the context > representation is cleaner compared to Phabricator and one can easily > navigate between different amendment revisions of one change), and it is > integrated with Git with a customizable workflow (e.g. can have complex > submit requirements, like a change must be approved by a different person= , > has to pass certain presubmit workflow, etc.) and is actively developed a= nd > maintained (both Android and Chrome makes heavy use of Gerrit). > > Cheers, > > On Tue, Apr 23, 2024 at 12:02=E2=80=AFPM Gleb Smirnoff <glebius@freebsd.o= rg> > wrote: > >> Lexi, >> >> On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote: >> L> as a non-committer src contributor, i've discussed this with imp@ >> quite >> L> a bit and i think this should be phrased more strongly in favour of >> L> using GitHub for commits. >> L> >> L> the current situation is that Phabricator is useless for non-committe= rs >> L> because 1) you have to know who can review your commit, and 2) once >> your >> L> commit is reviewed, someone has to commit it, and Phabricator doesn't >> L> address this. >> >> The 1) is actually not as bad. Phabricator has subscribtion hooks, and >> many >> committers have rules installed to get notifications of new reviews that >> touch certain paths of code. >> >> The problem 2), IMHO, equally applies to github and Phabricator. >> >> L> i think it might make more sense to suggest that people submit all >> L> patches via either GitHub or Bugzilla, and only use Phabricator if >> L> specifically asked to. >> >> I don't agree here. Looks like we should address those phabricator >> submissions that go unnoticed due to lack of maintainers of a code. >> I don't think submitting same patch to github will improve visibility. >> >> >> -- >> Gleb Smirnoff >> > --0000000000009d821d0616c8c987 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>We have thought about it. People are setting one (for= gejo) up right now as a proof of</div><div>concept. Contact me if you'd= like to participate, or setup something different to evaluate (past</div><= div>calls for the git next generation working group didn't produce too = many interested parties</div><div>that could move the ball). In the long te= rm, though, we'll have to do something like Gerrit,</div><div>Gitlab, o= r Forgejo or similar. There's a lot of factors to consider for each of = the solutions</div><div>that are available, but it's hard to setup some= thing even as a test experiment to see if</div><div>it can make things bett= er.</div><div><br></div><div>Github pull requests are my attempt=C2=A0to do= something to move the needle on the</div><div>project being so hard to con= tribute to in a way that won't get ignored. There's plenty</div><di= v>of problems with it, but we're also getting some good code and contri= butors from it.</div><div>Nothing is stopping other attempts, other than th= e time and effort it takes to set them</div><div>up and administer them....= </div><div><br></div><div>Warner</div><div><br></div><div class=3D"gmail_qu= ote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 23, 2024 at 1:34=E2= =80=AFPM Xin LI <<a href=3D"mailto:delphij@gmail.com">delphij@gmail.com<= /a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0= px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><= div dir=3D"ltr"><div style=3D"font-family:monospace,monospace">Possibly sli= ghtly off-topic, but have we considered some other alternatives to Phabrica= tor, like <a href=3D"https://www.gerritcodereview.com/" target=3D"_blank">G= errit</a>?=C2=A0 (My opinion might be biased as we use Gerrit at $WORK).=C2= =A0 I liked the review UI more (the context representation is cleaner compa= red to Phabricator and one can easily navigate between different amendment = revisions of one change), and it is integrated with Git with a customizable= workflow (e.g. can have complex submit requirements, like a change must be= approved by a different person, has to pass certain presubmit workflow, et= c.) and is actively developed and maintained (both Android and Chrome makes= heavy use of Gerrit).</div><div style=3D"font-family:monospace,monospace">= <br></div><div style=3D"font-family:monospace,monospace">Cheers,<br></div><= /div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">O= n Tue, Apr 23, 2024 at 12:02=E2=80=AFPM Gleb Smirnoff <<a href=3D"mailto= :glebius@freebsd.org" target=3D"_blank">glebius@freebsd.org</a>> wrote:<= br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e= x;border-left:1px solid rgb(204,204,204);padding-left:1ex">=C2=A0 Lexi,<br> <br> On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote:<br> L> as a non-committer src contributor, i've discussed this with imp@= quite<br> L> a bit and i think this should be phrased more strongly in favour of<b= r> L> using GitHub for commits.<br> L> <br> L> the current situation is that Phabricator is useless for non-committe= rs<br> L> because 1) you have to know who can review your commit, and 2) once y= our<br> L> commit is reviewed, someone has to commit it, and Phabricator doesn&#= 39;t<br> L> address this.<br> <br> The 1) is actually not as bad.=C2=A0 Phabricator has subscribtion hooks, an= d many<br> committers have rules installed to get notifications of new reviews that<br= > touch certain paths of code.<br> <br> The problem 2), IMHO, equally applies to github and Phabricator.<br> <br> L> i think it might make more sense to suggest that people submit all<br= > L> patches via either GitHub or Bugzilla, and only use Phabricator if<br= > L> specifically asked to.<br> <br> I don't agree here. Looks like we should address those phabricator<br> submissions that go unnoticed due to lack of maintainers of a code.<br> I don't think submitting same patch to github will improve visibility.<= br> <br> <br> -- <br> Gleb Smirnoff<br> </blockquote></div> </blockquote></div></div> --0000000000009d821d0616c8c987--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrdjT6D_=a2n6q3Vgq-cJqx6wVg0QTv7kgJXi9mMAa5Hg>