Date: Tue, 24 Mar 2009 17:06:32 +0100 From: Gustau Perez <gperez@entel.upc.edu> Cc: freebsd-current@freebsd.org Subject: Re: Inline definition problem in current Message-ID: <49C90508.4030500@entel.upc.edu> In-Reply-To: <790a9fff0903240842k6ab28ab5k1d1a46714fdfe804@mail.gmail.com> References: <49C80DBA.80407@entel.upc.edu> <D7A9B95D-AD8D-4F2A-B077-E48E9296EAEB@wanderview.com> <790a9fff0903240842k6ab28ab5k1d1a46714fdfe804@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>>
>> It seems like they might be related.
>>
>>
>> Hope that helps.
>>
>>
Yes it did.
> I can confirm that reverting this change allows the audio/faad port to build.
>
>
Instead of reverting that change, it would be better to change the
offeding inline function definition to something like :
extern inline [return type|void] __attribute__((gnu_inline))
function_name(arg1,arg2,...)
and the function implementation should be the same without the
extern. That allowed me to compile compiz-fusion-plugins-main
in current and run it. I'm found the problem you faced, but didn't know
how to fix it, so I used an static inline definition (which is not the
solution).
I'm going to try this patch in stable branch (which doesn't need this
change). If it works a PR can be send to fix both current and stable
without tricks in the makefile.
Greets,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49C90508.4030500>