Date: Fri, 6 Nov 1998 14:14:09 -0800 (PST) From: "Dag-Erling C. Sm\xf8rgrav" <des@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/lib/libfetch fetch_err.et Makefile common.c common.h fetch.3 fetch.c fetch.h file.c ftp.c ftp.errors http.c http.errors Message-ID: <199811062214.OAA00313@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
des 1998/11/06 14:14:09 PST
Modified files:
lib/libfetch Makefile common.c common.h fetch.3
fetch.c fetch.h file.c ftp.c ftp.errors
http.c http.errors
Added files:
lib/libfetch fetch_err.et
Log:
Second of a series of cleanups to libfetch.
This commit introduces the following features:
a) the fetchStat*() functions, which return meta-information for a
document, such as size, modification time, etc.
b) the use of the com_err(3) facilities to report errors.
It also fixes a bunch of style bugs and a few logic bugs and somewhat
improves the man page.
Changed files, in alphabetical order:
Makefile:
Don't generate macros in {ftp,http}err.c.
Generate category fields for the error message lists.
Compile the error table.
Install fetch_err.h along with fetch.h.
common.c:
Remove the _netdb_errstring() macro, and add FETCH_ERR_NETDB to the
error code in the _netdb_seterr() macro.
Add categories to the _netdb_errlist table.
Report errors through the Common Error library.
common.h:
Add the DEBUG macros.
Add prototype for fetchConnect().
Remove the prototype for _fetch_errstring(), which is local to common.c
Add a categroy field to struct fetcherr, and define constants for
error categories.
Define macros for _{url,netdb,ftp,http}_seterr().
errors.et: (new file)
List error categories.
fetch.3:
Document the fetchStat*() functions.
Move the "unimplemented functionality" comments from NOTES to BUGS.
Document that applications which use libfetch must also use
libcom_err, and list existing error codes.
Undocument fetchLastErr{Code,String}.
Remove the (empty) DIAGNOSTICS section.
Mention Eugene Skepner in the AUTHORS section.
fetch.c:
Move the DEBUG macros to common.c
Add fetchStat() and fetchStatURL().
Generate error messages for URL parser errors, and fix a minor bug
in the parser.
Use 'struct url' instead of 'url_t'.
Remove fetchLastErr{Code,String}.
fetch.h:
Use 'struct url' instead of 'url_t', and remove the typedef.
Define struct url_stat (used by fetchStat()).
Add prototypes for fetchStat*().
Remove the declarations for fetchLastErr{Code,String}.
Include fetch_err.h.
fetch_err.et: (new file)
Error table for libfetch.
file.c:
Add fetchStatFile().
Use 'struct url' instead of 'url_t'.
ftp.c:
Add fetchStatFTP().
Use 'struct url' instead of 'url_t'.
Don't use fetchLastErrCode.
ftp.errors:
Add categories to all error messages.
http.c:
Add fetchStatHTTP().
Use 'struct url' instead of 'url_t'.
Don't use fetchLastErr{Code,Text}.
http.errors:
Add categories to all error messages.
Prompted by: jkh and Eugene Skepner
Numerous sugestions from: Garett Wollman and Eugene Skepner
Revision Changes Path
1.7 +19 -18 src/lib/libfetch/Makefile
1.2 +89 -18 src/lib/libfetch/common.c
1.2 +16 -4 src/lib/libfetch/common.h
1.4 +124 -38 src/lib/libfetch/fetch.3
1.6 +89 -23 src/lib/libfetch/fetch.c
1.6 +31 -27 src/lib/libfetch/fetch.h
1.2 +36 -7 src/lib/libfetch/file.c
1.7 +22 -11 src/lib/libfetch/ftp.c
1.2 +40 -40 src/lib/libfetch/ftp.errors
1.7 +16 -7 src/lib/libfetch/http.c
1.2 +38 -38 src/lib/libfetch/http.errors
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811062214.OAA00313>