Date: Mon, 9 Oct 2017 17:13:00 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r451553 - in head/ports-mgmt/portlint: . src Message-ID: <20171009171300.GA99808@FreeBSD.org> In-Reply-To: <98416211-8e18-7d8f-b10d-c295e96fd363@freebsd.org> References: <201710081758.v98HwqIe003342@repo.freebsd.org> <e577bff2-63cf-7411-74e1-f587e4dee31f@FreeBSD.org> <98416211-8e18-7d8f-b10d-c295e96fd363@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 09, 2017 at 12:40:00PM -0400, Joe Marcus Clarke wrote: > On 10/9/17 12:07, Mathieu Arnold wrote: > > Le 08/10/2017 ?? 19:58, Joe Marcus Clarke a ??crit : > >> New Revision: 451553 > >> URL: https://svnweb.freebsd.org/changeset/ports/451553 > >> > >> Log: > >> Update to 2.17.13. > >> > >> * Do not complain about USE_GITHUB before USES [1] > > > > This is wrong. USES= must always happen before any other USE_* variable. > > This was my thought, but the argument around a "fetch" USE_* versus > other build USE_* made sense. I'm happy to go with consensus here. Right; and the fact that we don't have (or plan to get) `Mk/Uses/github.mk' makes "USES= must always happen before any other USE_*" claim semantically irrelevant in this case. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171009171300.GA99808>