Date: Wed, 10 May 2023 09:26:48 GMT From: =?utf-8?Q?Dag-Erling=20Sm=C3=B8rgrav?= <des@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: facc213643f8 - main - md5: Don't increment a bool. Message-ID: <202305100926.34A9Qm1B092846@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=facc213643f80bbdb0ebd76f5b26de84d95b9e1a commit facc213643f80bbdb0ebd76f5b26de84d95b9e1a Author: Dag-Erling Smørgrav <des@FreeBSD.org> AuthorDate: 2023-05-09 17:59:27 +0000 Commit: Dag-Erling Smørgrav <des@FreeBSD.org> CommitDate: 2023-05-10 09:25:21 +0000 md5: Don't increment a bool. Fixes: 4849767cb16a MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D40020 --- sbin/md5/md5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c index b11fc6971735..202cc830d4ed 100644 --- a/sbin/md5/md5.c +++ b/sbin/md5/md5.c @@ -662,7 +662,7 @@ main(int argc, char *argv[]) } if (failed) return (1); - if (checksFailed != 0) + if (checksFailed > 0) return (2); return (0); @@ -759,7 +759,7 @@ MDOutput(const Algorithm_t *alg, char *p, const char *name) if (p == NULL) { warn("%s", name); - failed++; + failed = true; } else if (cflag && mode != mode_bsd) { checkfailed = strcasecmp(checkAgainst, p) != 0; if (!sflag && (!qflag || checkfailed)) @@ -1001,7 +1001,7 @@ MDTestSuite(const Algorithm_t *alg) printf(" - verified correct\n"); } else { printf(" - INCORRECT RESULT!\n"); - failed++; + failed = true; } } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202305100926.34A9Qm1B092846>