Date: Tue, 15 Jan 2008 11:14:23 -0500 (EST) From: Naram Qashat <cyberbotx@cyberbotx.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: lev@FreeBSD.org Subject: ports/119688: [PATCH] devel/mingw32-binutils: Correct ld build problem Message-ID: <20080115161423.D43F7C13C@kirby.cyberbotx.com> Resent-Message-ID: <200801151620.m0FGK2V0090496@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 119688 >Category: ports >Synopsis: [PATCH] devel/mingw32-binutils: Correct ld build problem >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 15 16:20:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Naram Qashat >Release: FreeBSD 6.2-RELEASE-p8 i386 >Organization: >Environment: System: FreeBSD kirby.cyberbotx.com 6.2-RELEASE-p8 FreeBSD 6.2-RELEASE-p8 #12: Sun Oct 14 16:14:35 EDT 2007 >Description: When mingw32-binutils got to the genscripts.sh part of building ld, it would fail with the message: .././ld/genscripts.sh: 403: Syntax error: Bad substitution I couldn't find the exact reason for this, but it was in a section specific to bash syntax and not sh syntax. Removing the bash portion allows the script to complete with no issues. Note: I do have bash installed, but my /bin/sh is not bash. So I am still at a loss for why it would run the bash section of the script. Note 2: I didn't bump PORTREVISION because this is a minor change. Added file(s): - files/patch-ld-genscripts.sh Port maintainer (lev@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- mingw32-binutils-2.18,1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/devel/mingw32-binutils/files/patch-ld-genscripts.sh /kirby/shared/ports/mingw32-binutils/files/patch-ld-genscripts.sh --- /usr/ports/devel/mingw32-binutils/files/patch-ld-genscripts.sh Wed Dec 31 19:00:00 1969 +++ /kirby/shared/ports/mingw32-binutils/files/patch-ld-genscripts.sh Tue Jan 15 11:05:52 2008 @@ -0,0 +1,41 @@ +--- ld/genscripts.sh.orig Sun Aug 12 15:00:07 2007 ++++ ld/genscripts.sh Tue Jan 15 11:04:56 2008 +@@ -390,30 +390,14 @@ + *" ${EMULATION_NAME} "*) COMPILE_IN=true;; + esac + +-if test -n "${BASH+set}"; then +- source_em() +- { +- local current_script="$em_script" +- em_script=$1 +- . $em_script +- em_script=$current_script +- } +- fragment() +- { +- local lineno=$[${BASH_LINENO[0]} + 1] +- echo >> e${EMULATION_NAME}.c "#line $lineno \"$em_script\"" +- cat >> e${EMULATION_NAME}.c +- } +-else +- source_em() +- { +- . $1 +- } +- fragment() +- { +- cat >> e${EMULATION_NAME}.c +- } +-fi ++source_em() ++{ ++ . $1 ++} ++fragment() ++{ ++ cat >> e${EMULATION_NAME}.c ++} + + # Generate e${EMULATION_NAME}.c. + # Start with an empty file, then the sourced .em script --- mingw32-binutils-2.18,1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080115161423.D43F7C13C>