Date: Fri, 24 Apr 2009 15:30:08 GMT From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: freebsd-multimedia@FreeBSD.org Subject: Re: ports/132407: [patch] multimedia/ffmpeg: respect TMPDIR passed from make.conf Message-ID: <200904241530.n3OFU8Sc008963@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/132407; it has been noted by GNATS.
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: ahze@FreeBSD.org, marcus@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/132407: [patch] multimedia/ffmpeg: respect TMPDIR passed
from make.conf
Date: Fri, 24 Apr 2009 19:23:24 +0400
Pav, good day.
Fri, Apr 24, 2009 at 09:08:47AM +0200, Pav Lucistnik wrote:
> This is not a good patch. All ./configure using ports have the same
> issue. I don't see why we should address this is ffmpeg port.
> Either you fix this generally in bsd.port.mk (and I see bsd.kde.mk
> already have the proposed fix), or you should put
> CONFIGURE_ENV=3D"TMPDIR=3D/var/tmp" to your /etc/make.conf instead.
I think that I'll better fix bsd.port.mk: the new patch is below.
bsd.kde.mk passed TMPDIR down only for package building, but I think
that my modification should pass it always.
Thanks for suggestions!
--- bsd.port.mk-pass-TMPDIR.diff begins here ---
=46rom d12eb79d31daea3ea9e16bd932b9de333a0cf63f Mon Sep 17 00:00:00 2001
=46rom: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Date: Fri, 24 Apr 2009 19:17:35 +0400
Subject: [PATCH] bsd.port.mk: pass TMPDIR from /etc/make.conf down to the t=
ools
Sometimes ports want to put executables to the $TMPDIR (/tmp by-default)
during configure/build stages. Such ports will be broken when /tmp is
mounted with 'noexec' flag. This patch addresses this problem and
allows automated port builds (e.g. via portupgrade) with TMPDIR set from
/etc/make.conf.
Signed-off-by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
---
Mk/bsd.port.mk | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk
index 324ed4a..647ac62 100644
--- a/Mk/bsd.port.mk
+++ b/Mk/bsd.port.mk
@@ -1292,6 +1292,13 @@ WITHOUT_${W}:=3D true
=20
DOS2UNIX_REGEX?=3D .*
=20
+# Respect TMPDIR passed via make.conf or similar and pass it down
+# to configure and make.
+.ifdef TMPDIR
+MAKE_ENV+=3D TMPDIR=3D"${TMPDIR}"
+CONFIGURE_ENV+=3D TMPDIR=3D"${TMPDIR}"
+.endif # TMPDIR
+
=20
# Start of pre-makefile section.
.if !defined(AFTERPORTMK) && !defined(INOPTIONSMK)
--=20
1.6.2.4
--- bsd.port.mk-pass-TMPDIR.diff ends here ---
--=20
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook
{_.-``-' {_/ #
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904241530.n3OFU8Sc008963>