Date: Sun, 05 Oct 2003 15:51:11 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Piero <piero@poprostu.pl> Cc: freebsd-gnome@freebsd.org Subject: Re: [new port] GNUGadu2 final shot? Message-ID: <1065383471.15483.24.camel@shumai.marcuscom.com> In-Reply-To: <20031005125233.M87991@poprostu.pl> References: <20031005125233.M87991@poprostu.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-QQpFVeb1r9lttGrggb4t
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2003-10-05 at 09:02, Piero wrote:
> HI,
>=20
> So this is supposed to be the final version of the new port of GNU=20
> Gadu 2, GTK2 based development version of Polish IM client for=20
> Gadu-Gadu protocol very popular here. See: polish/gnugadu for gtk1.2=20
> old version.
A few things here:
* You should use ${ECHO_MSG} not ${ECHO_CMD} when displaying messages to
the user
* Never check for the existence of a directory (in fact, check into
WANT_GNOME for some of what you're doing)
* Your port installs libtool .la files. You should set USE_LIBTOOL, and
borrow the configure patch from, say, gtk20
* Don't use WITH_ESOUND. Use WANT_GNOME, and check for
${HAVE_GNOME:Mesound}!=3D"" (checkout gstreamer-plugins for an example)
* LIB_DEPENDS on ekg needs to appear right below the COMMENT in its own
paragraph
* pre-everything:: _usually_ comes first in the list of targets
* Sort the plist lexicographically for installed items, and reverse
lexicographically for @dirrms
Joe
>=20
> I am attaching two shars, one for the gnugadu2 and another for an=20
> optional dependency which would have its own PR (there are some=20
> issues with distfiles in libtlen, so I will wait till they are=20
> resolved).
>=20
> Can you have a look at this? I want to file a PR, so I would like to=20
> avoid silly mistakes. Thanks,
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-QQpFVeb1r9lttGrggb4t
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQA/gHYvb2iPiv4Uz4cRAtJXAKCl/MnjwbpjcFGlTRGrP7KXGiyO6gCgkWiB
EdXx6elwNa7GgMAq8owjCD4=
=6AqV
-----END PGP SIGNATURE-----
--=-QQpFVeb1r9lttGrggb4t--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1065383471.15483.24.camel>