Date: Tue, 15 Jan 2008 23:13:27 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Kris Kennaway <kris@FreeBSD.org> Cc: Tim Kientzle <tim@kientzle.com>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Tim Kientzle <kientzle@FreeBSD.ORG>, obrien@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c Message-ID: <86y7aqbuuw.fsf@ds4.des.no> In-Reply-To: <478BE651.1020901@FreeBSD.org> (Kris Kennaway's message of "Mon\, 14 Jan 2008 23\:46\:41 %2B0100") References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <20080114223239.GC56062@VARK.MIT.EDU> <478BE651.1020901@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway <kris@FreeBSD.org> writes: > No, you'd have to duplicate the do-extract code (or add a special > variable for those 4 ports). I'd much rather wait to see what Tim and > Dag-Erling can come up with. Take it easy everyone, no special-casing will be necessary as I fully intend to add support for them to libarchive. The four files I've identified are: /usr/ports/distfiles/XMMS-AfterStep.zip /usr/ports/distfiles/mathfonts-4.1/MathFonts_TrueType_41.exe /usr/ports/distfiles/q2-3.20-x86-full.exe /usr/ports/distfiles/wordsall.zip Two of them are self-extracting. There is no easy way to figure out how much to skip. I wrote a PE decoder which located the correct section, but the zip file is preceded by decoder-specific data which I couldn't decode. The correct starting position can be obtained from the central directory, which is at the end of the file, which means libarchive needs full seek support. I am working on that, but it requires a few changes in the API between the libarchive core and the support modules, which is a published API, so I need to discuss this with Tim (who until recently was away on vacation). AFAICT, the other two files simply have a dummy local header ("PK00") at the beginning, which requires a trivial modification to the existing zip support code to handle. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y7aqbuuw.fsf>