Date: Sun, 15 Feb 1998 00:13:32 +0900 From: Masafumi NAKANE/=?iso-2022-jp?B?GyRCQ2Y6LDJtSjgbKEI=?= <max@wide.ad.jp> To: vanilla@FreeBSD.ORG Cc: max@wide.ad.jp Subject: Re: cvs commit: ports/chinese/samba-des Makefile ports/chinese/samba-des/files md5 smb.conf.sample ports/chinese/samba-des/patches patch-aa patch-ab patch-ac ports/chinese/samba-des/pkg COMMENT DESCR PLIST Message-ID: <19980215001332E.masafumi@aslm.rim.or.jp> In-Reply-To: Your message of "Fri, 13 Feb 1998 10:30:11 -0800 (PST)" <199802131830.KAA24187@freefall.freebsd.org> References: <199802131830.KAA24187@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> vanilla 1998/02/13 10:30:10 PST
> Removed files:
> chinese/samba-des Makefile
> chinese/samba-des/files md5 smb.conf.sample
> chinese/samba-des/patches patch-aa patch-ab patch-ac
> chinese/samba-des/pkg COMMENT DESCR PLIST
> Log:
> remove zh-samba-des.
IMO, this log message is nearly meaningless because:
1. If you are reading the commiters list, then it is obvious that it
is being removed from the ``Removed file:'' part of the message.
2. If you are trying to find out something using the cvs commands, it
is obvious it has been removed as you can't use the module name to do
any operation, or even if you specify full module path, you get empty
directories.
Instead, what we really expect from the log message is the reason why
this is removed rather than the fact it is removed.
As people more often look at commit logs through e-mails, I think many
people tend to forget the primary purpose of log message, which is for
reference in future. In general, we need to pay more attention to the
log message when committing any changes. Let's think carefully what
we expect from the log when we will do cvs log in future as we do cvs
ci.
Cheers,
Max
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980215001332E.masafumi>