Date: Thu, 22 Jul 2004 15:38:44 +0300 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Tim Robbins <tjr@freebsd.org> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/ntp config.h src/usr.sbin/ntp/ntpdc Makefile src/usr.sbin/ntp/ntpq Makefile Message-ID: <20040722123844.GB5479@orion.daedalusnetworks.priv> In-Reply-To: <20040722115827.GA6110@cat.robbins.dropbear.id.au> References: <200407220814.i6M8EbKM092483@repoman.freebsd.org> <20040722105914.GA4708@orion.daedalusnetworks.priv> <20040722115827.GA6110@cat.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2004-07-22 21:58, Tim Robbins <tjr@freebsd.org> wrote: >On Thu, Jul 22, 2004 at 01:59:15PM +0300, Giorgos Keramidas wrote: >>On 2004-07-22 08:14, Ollivier Robert <roberto@freebsd.org> wrote: >>> >>> Allow ntpd to be compiled w/o readline when NO_GNU is defined. Part >>> of a larger patchset to get a GNU-free world. >>> >>> Patch rewritten to cope with the 4.2.0 changes. >> >> Just a thought, without having looked at the source of ntp stuff. >> >> Would it be extremely difficult or cause conflict/merge problems if we >> replaced readline with libedit in the NO_GNU case? > > NetBSD not-so-recently added GNU readline emulation to their libedit. > Last time I looked, they'd made a mess of the code with #ifdefs, but it'd > still be possible to bring across the useful bits. Err, no that would be ugly. I don't like excessive use of #ifdefs but that's probably a different topic. I was thinking of something more like: use this getline() function, which will magically work through readline() or el_get() depending on which file was added to SRCS at compile-time (depending on WITH_READLINE or not). > FWIW, I really don't see the point of partial support for building > GNU-free systems. It sounds like something that should be kept as > a local diff. Hmmm, yes well... I'll see if I can do something not too ugly but still useful as a proof-of-concept diff when the commits to the ntp utils are all done.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040722123844.GB5479>