Date: Thu, 26 Feb 2026 19:46:09 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Michael Tuexen <tuexen@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket Message-ID: <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com> In-Reply-To: <699ef25d.42e41.7579887f@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi Michael! > On Feb 25, 2026, at 5:00 AM, Michael Tuexen <tuexen@FreeBSD.org> wrote: > > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=454212b9718b55b43781f81bef252658e20e0fd3 … > @@ -171,7 +173,7 @@ sys_sctp_peeloff(struct thread *td, struct sctp_peeloff_args *uap) > td->td_retval[0] = fd; > > CURVNET_SET(head->so_vnet); > - so = sopeeloff(head); > + so = sopeeloff(head, &sctp_stream_protosw); This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right? Thanks! -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmhE4EACgkQGpE5DjPs NJiDNxAAk7DpomOwPWW6ag5cb5943La5OLtCEX+BNUiOgDf1mw6Ysxl3W310V6rH eKQdS3cPgjlQkgeMib+Epxbl3lPmVyVoPLBJKsG+k0iBqhPp3bnRhZ9h7hue7xPc HubfQ2qIePJG/q0lthxMH7352zFT0C8GqtRTjAEOELQnmdV2FIYI+19mFF3mnfCh kVF3AGa8KADuQxPGCpGHlm1CCe4u8qxZLdYQLwemknxAXvwaOVq7AGiZnBGO8EdU yibvNqaCZkd0QdBW5h96zCXUaI4eKo5QPnsUnDIvsC1K/QnpA0LRSly26D7NixeF EB9hG+w0heGG2Al00/vICRVFI/FG7kohJ2sf++p0SvcO/T7ROppEr8A/zdvulzDq QVy5FLG/a5xLW9iTcEepf8wEyaMMarvSfUiA1//e48eFjw4VqCihbF3ozqQfcHZX UJnf7U1TU+N3RPSZTl0ZDeJ3B2RWTklcyfb4l9pmbgiDVgSz210A3mfafGCjwrsv 1OzCwaq62sC8Sx9WBuUIkQDyISLm43lpKAQHGx/odmvXRrf6IVz+ykyv0YYN7hbV aoMC+br29TkOCKLjvaDO55cSc0E2OJs5LzVFOSJ0RFujNwJb3u1bznMVC01KrG+L pKFFEqpn3tU/Xh4u8BnGrWU28DiehLlSA6MInnhQodbhxka5BJY= =haaJ -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DA9B5022-602F-4720-9473-191B1A20B6B5>