Date: Thu, 4 Nov 2004 10:32:21 +0100 From: Arjan de Vet <devet@devet.org> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/73038: if_sk.c seems to need IFF_NEEDSGIANT on 5.3-BETA/RC1 Message-ID: <20041104093221.GA6839@adv.devet.org> In-Reply-To: <20041101202617.GB1020@adv.devet.org> References: <20041023121049.A20631938D@adv.devet.org> <200410231220.i9NCKEjC016756@freefall.freebsd.org> <20041101191610.GA1019@adv.devet.org> <20041101202617.GB1020@adv.devet.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm happy to report that the following patch by Peter Edwards (posted to
a.o. current) fixes the symptoms I reported. My sk0 interface is now
running 12+ hours without debug.mpsafenet=0 in /boot/loader.conf without
problems.
From: Peter Edwards <peadar.edwards@gmail.com>
CC: FreeBSD current mailing list <current@freebsd.org>
CC: freebsd-amd64@freebsd.org
Subject: Re: if_sk patch to get more info from people with problems
[...]
--- /tmp/if_sk.c Tue Nov 2 17:49:26 2004
+++ if_sk.c Tue Nov 2 17:52:20 2004
@@ -1115,12 +1115,14 @@
if ((i < 0) || (i >= SK_JSLOTS))
panic("sk_jfree: asked to free buffer that we don't manage!");
+ SK_LOCK(sc_if->sk_softc);
entry = SLIST_FIRST(&sc_if->sk_jinuse_listhead);
if (entry == NULL)
panic("sk_jfree: buffer not in use!");
entry->slot = i;
SLIST_REMOVE_HEAD(&sc_if->sk_jinuse_listhead, jpool_entries);
SLIST_INSERT_HEAD(&sc_if->sk_jfree_listhead, entry, jpool_entries);
+ SK_UNLOCK(sc_if->sk_softc);
return;
}
Arjan
--
Arjan de Vet, Eindhoven, The Netherlands <devet@devet.org>
URL : http://www.devet.org/ <Arjan.deVet@adv.iae.nl>
Work: http://www.madison-gurkha.com/ (Security, Open Source, Education)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041104093221.GA6839>