Date: Wed, 18 Nov 2009 07:28:40 -0500 From: Ben Kelly <ben@wanderview.com> To: Gonzalo Nemmi <gnemmi@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: WITHOUT_MODULES, does it actually work? Message-ID: <0EB6E028-BA0A-48F1-AE7B-9F5E0A97B432@wanderview.com> In-Reply-To: <19e9a5dc0911171944q5d15dc96t83ecd53befb07621@mail.gmail.com> References: <200911172021.16848.gnemmi@gmail.com> <41D86F39-D98A-4195-8345-765E0F742FAE@wanderview.com> <19e9a5dc0911171614l42f4c90ci2abce9982727ef61@mail.gmail.com> <4B033E22.3060700@FreeBSD.org> <8727F2A4-B830-43EE-BB9B-A17798374C00@wanderview.com> <4B034899.9090408@FreeBSD.org> <BB106D32-DF64-4086-801F-286050314200@wanderview.com> <19e9a5dc0911171944q5d15dc96t83ecd53befb07621@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Nov 17, 2009, at 10:44 PM, Gonzalo Nemmi wrote:
> On Tue, Nov 17, 2009 at 10:59 PM, Ben Kelly <ben@wanderview.com> wrote:
>
>>
>> On Nov 17, 2009, at 8:06 PM, Doug Barton wrote:
>>
>>> Ben Kelly wrote:
>>>> It seems there are some left over bits then. I have this in
>> /usr/src/sys/modules/Makefile:
>>>>
>>>> .for reject in ${WITHOUT_MODULES}
>>>> SUBDIR:= ${SUBDIR:N${reject}}
>>>> .endfor
>>>
>>> Well it seems my search was not exhaustive.
>>>
>>> My recommendation then would be to file a src PR so that someone can
>>> look into it. :)
>>
>> I've opened a doc PR for the bad example in the handbook and a conf PR for
>> the patch to make WITHOUT_MODULES work from the kernel config file using
>> makeoptions. I haven't gotten PR numbers back from the system yet.
>>
>> - Ben_______________________________________________
>
>
> So, basically .. not only man make.conf and the handbook examples are wrong
> .. WITHOUT_MODULES doesn't actually work :s
>
> Thanks a lot for your research, testing, PR and patches Ben !
> Please, should you be able to, I would like to know the PR number so I can
> follow it.
> Hope your patch makes it in and WITHOUT_MODULES works as expected :)
No problem.
Just to clarify, though. The content of man make.conf looks correct to me and the variable did work if you put it in /etc/make.conf. The only issues I saw were the example in the handbook and the failure of makeoptions in the kernel config file.
I do think you could get a number of the modules in your original list excluded if you specified them differently:
WITHOUT_MODULES=firewire bwi bce bfe iwi iwn zfs
Basically remove the dev/ prefix you have on some of them.
Hope that helps.
- Ben
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0EB6E028-BA0A-48F1-AE7B-9F5E0A97B432>