Date: Sat, 17 Jan 2015 10:37:49 +0100 From: Palle Girgensohn <girgen@pingpong.net> To: Baptiste Daroussin <bapt@freebsd.org> Cc: "pgsql@FreeBSD.org" <pgsql@FreeBSD.org>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org>, Waitman Gobble <gobble.wa@gmail.com> Subject: Re: postgresql93 port and libedit Message-ID: <171ED59D-E445-4605-B72C-E9ED8A74CA28@pingpong.net> In-Reply-To: <20150117004151.GO98528@ivaldir.etoilebsd.net> References: <CAFuo_fzX5i357NofZ2DFkz_=qDZzdNdGKdT8RfhoTN-wo=YDSA@mail.gmail.com> <20150115160113.GE98528@ivaldir.etoilebsd.net> <CAFuo_fxXu05ELWtB3GSjhC0-fk_cjEv8QN4LTgyxdsaC%2BXLXow@mail.gmail.com> <20150117004151.GO98528@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
17 jan 2015 kl. 01:41 skrev Baptiste Daroussin <bapt@freebsd.org>:
> On Thu, Jan 15, 2015 at 08:02:22PM -0800, Waitman Gobble wrote:
>> On Thu, Jan 15, 2015 at 8:01 AM, Baptiste Daroussin <bapt@freebsd.org> wr=
ote:
>>> On Wed, Jan 14, 2015 at 10:27:14PM -0800, Waitman Gobble wrote:
>>>> Hi,
>>>>=20
>>>> I noticed that postgresql93-client port pulls in readline, which is GPL=
v3.
>>>> When I get rid of readline in Makefile 'USES' and also change the
>>>> bottom of the Makefile in postgresql93-server,
>>>>=20
>>>> ...
>>>> .include "${.CURDIR}/../postgresql92-server/Makefile"
>>>>=20
>>>> CONFIGURE_ARGS+=3D--with-libedit-preferred
>>>>=20
>>>>=20
>>>> It builds without readline and links against libedit in base:
>>>>=20
>>> except that libedit is not really an alternative as it does not supprot u=
nicode
>>> (except in head) one solution would be to try linking against the editli=
ne port
>>> which contains the same fixes as libedit in head and see if it works.
>>>=20
>>> Best regards,
>>> Bapt
>>=20
>> Thanks so much for the feedback. I've considered the options regarding
>> my project and I think it's more work to handle end-user devices with
>> a pkg repository if I indeed must manage custom ports built using
>> customized sources. Distributing the initial appliance isn't the
>> problem, i'm working out an update strategy for down the road.
>>=20
>=20
> https://people.freebsd.org/~bapt/pglibedit.diff
>=20
> This patch works for me and accepts perfectly unicode.
>=20
> Can anyone from the postgresql team test, generalize to other postegresql
> versions? (please keep it using the port version of libedit).
>=20
> Best regards,
> Bapt
Hi,
Looks like a reasonable patch. I have a hard time finding the differences be=
tween readine and ilbedit. It aims at 100% API compatibility. How good is li=
bedit? If it degrades functionality compared to readline it should really be=
an option, but I agree, lesser options are preferred.=20
Palle=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?171ED59D-E445-4605-B72C-E9ED8A74CA28>