Date: Fri, 4 Oct 2024 12:40:19 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <5qanx7v222zl6gawtepv7poftvheldluxoseone2ebevxv3bne@2a7yhel63ul2> In-Reply-To: <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
On Oct 04 2024, 03:34 +0000, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: >>> do-test section can be replaced with USES= cmake:testing >>> >>> https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 >> >> I wasn't able to do it with cmake:testing. Were you? > >Upstream uses from what I can tell an rather old approach for test >target, > >https://github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt#L160 > >The "EXCLUDE FROM ALL" part is what causes the issue Thanks, I'll remove that. >>> It also seems to look for Doxygen by default >>> >>> which you probably want to disable to avoid potential plist >>> issues. >> >> Well, they don't provide a way to turn off docs, but I don't see an >> >> issue with it building docs if it finds doxygen. We won't be >> installing >> >> them anyway. > >https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html >works :-) I don't think this is at all necessary. But sure, I can set it (to CMAKE_ON, not to CMAKE_OFF like in your patch). >Patch: > >https://projects.pyret.net/files/freebsd-patches/createrepo_c-improve.patch I have taken a couple of suggestions, thanks. -- Pietro Cerutti I have pledged to give 10% of income to effective charities and invite you to join me - https://givingwhatwecan.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5qanx7v222zl6gawtepv7poftvheldluxoseone2ebevxv3bne>