Date: Tue, 27 Mar 2018 12:41:55 -0700 From: Oleksandr Tymoshenko <gonzo@bluezbox.com> To: Stefan Bethke <stb@lassitu.de> Cc: freebsd-hackers@FreeBSD.org Subject: Re: Bugzilla converts patch to CRLF line endings? Message-ID: <20180327194155.GA93992@bluezbox.com> In-Reply-To: <AC4C81D8-A928-4E8C-A067-EE83EBF044F1@lassitu.de> References: <AC4C81D8-A928-4E8C-A067-EE83EBF044F1@lassitu.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Stefan Bethke (stb@lassitu.de) wrote: > Hey, > > I’ve submitted patched for the ports I maintain by copy/pasting the svn diff output into the Bugzilla attachment form for a long time. The committer working on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226941 noticed that the patch apparently has CRLF line endings, making it hard(er) to apply it properly. > > Working on a Mac with Terminal and Safari, I have not have noticed any such behaviour. When I copy/paste from Bugzilla into Terminal, everything works just fine, so I can do „cd /usr/ports/cat/port; patch -p0“ then paste and ^D. > > When I download the attachment from the „raw“ attachment link (in my example https://bz-attachments.freebsd.org/attachment.cgi?id=191852) with curl or wget, I do get to see CR-LF. > > Where does that happen? And is that a bug or a feature? I think it's a standard: https://stackoverflow.com/a/14217315 Looks like browser is supposed to convert newlines in input field to CR LF. I just tried it on our test instance \r\n-s are part of a request, not added later. Bugzilla doesn't perfomr any transformation of copy-pasted attachment text and saves it as-is. -- gonzo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180327194155.GA93992>