Date: Tue, 22 Sep 2015 19:46:26 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes Message-ID: <A147C860-5BC0-47E6-99E2-6A91A133936D@FreeBSD.org> In-Reply-To: <1442931787.1224.205.camel@freebsd.org> References: <201509220935.t8M9ZZfD051027@repo.freebsd.org> <20150922094301.GW3158@zxy.spb.ru> <4CD0DC75-0235-4890-827C-4FF41BBADD8A@FreeBSD.org> <1442931787.1224.205.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_307ADA36-2350-41FD-898C-A6A18412F133 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 22 Sep 2015, at 16:23, Ian Lepore <ian@FreeBSD.org> wrote: > > On Tue, 2015-09-22 at 11:53 +0200, Dimitry Andric wrote: >> On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote: >>> >>> On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote: >> ... >>>> - imm |= (-1 << 7); >>>> + imm |= -(1 << 7); >>> >>> May be (~0 << 7) is more simple to understund? >> >> This will give the same warning. ~0 will implicitly convert to -1. >> >> (It would be better to convert all these masks to unsigned, where such >> shifting is always defined, but that gives a lot more churn.) >> >> -Dimitry >> > > How is (-1U << 7) more churn? For this one line, it isn't, of course. Writing -(1 << 7) is simply my personal preference, and it matches the type of 'imm'. But what I meant was changing all mask-containing int variables to unsigned, and suffixing all mask literals U, and so on. This is what should have been done by GNU in the first place. :) -Dimitry --Apple-Mail=_307ADA36-2350-41FD-898C-A6A18412F133 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.28 iEYEARECAAYFAlYBk/YACgkQsF6jCi4glqMrkQCfXZm7sEbmgnc2TQnEV84F1fua J2EAoJl0r19pDDLojwojDchEPrMoTo4N =7cUj -----END PGP SIGNATURE----- --Apple-Mail=_307ADA36-2350-41FD-898C-A6A18412F133--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A147C860-5BC0-47E6-99E2-6A91A133936D>