Date: Sat, 27 Jul 2002 16:20:05 -0700 (PDT) From: "M.J.Kouache" <bsdmail@rhoda.fsworld.co.uk> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/41063: Typo Message-ID: <200207272320.g6RNK5ix057815@www.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 41063
>Category: kern
>Synopsis: Typo
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jul 27 16:30:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: M.J.Kouache
>Release: MAIN & RELENG_4
>Organization:
>Environment:
unimportant
>Description:
There's a nasty typo in sys/dev/ata/atapi-all.c.
First look at the diff -c I have submitted as the fix,
especially notice that the buffer size has been increased.
If I really need to explain more, then read on,
(if not, goodbye and thanks for your time :-)
Version 1.10 of atapi-all.c in the MAIN source branch included a change in the error message, the new one is longer than the original and is now too large for the allocated buffer. This was introduced 3 years ago, and no-one's noticed yet, hence the non-critical severity of this pr.
At least this bug isn't as bad as the evil "<<" where it should be ">>" typo in the ata 48 bit addressing code, the fix to which has still not appeared in 4-STABLE yet btw.
>How-To-Repeat:
>Fix:
*** atapi-all.c Sat Jul 27 21:51:17 2002
--- atapi-all.fixed.c Sat Jul 27 21:51:57 2002
***************
*** 35,41 ****
case 0xbd: return ("MECH_STATUS");
case 0xbe: return ("READ_CD");
default: {
! static int8_t buffer[16];
sprintf(buffer, "unknown CMD (0x%02x)", cmd);
return buffer;
}
--- 35,41 ----
case 0xbd: return ("MECH_STATUS");
case 0xbe: return ("READ_CD");
default: {
! static int8_t buffer[20];
sprintf(buffer, "unknown CMD (0x%02x)", cmd);
return buffer;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207272320.g6RNK5ix057815>