Date: Sat, 22 Sep 2018 14:24:14 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: d@delphij.net Cc: Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338861 - head/lib/libc Message-ID: <20180922182414.mrm5oavdjeu6bb3y@mutt-hbsd> In-Reply-To: <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net> References: <201809211749.w8LHnbap091466@repo.freebsd.org> <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--v2fua2r66qnkigtm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 21, 2018 at 01:11:46PM -0700, Xin Li wrote: > On 9/21/18 10:49, Ed Maste wrote: > > Author: emaste > > Date: Fri Sep 21 17:49:37 2018 > > New Revision: 338861 > > URL: https://svnweb.freebsd.org/changeset/base/338861 > >=20 > > Log: > > libc: require ifunc-capable linker for amd64/i386 > > =20 > > We expect to introduce optimized libc routines in the near future, > > which requires use of a linker that supports ifuncs. > > =20 > > Approved by: re (gjb, kib) > > Sponsored by: The FreeBSD Foundation > >=20 > > Modified: > > head/lib/libc/Makefile > >=20 > > Modified: head/lib/libc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/Makefile Fri Sep 21 17:44:05 2018 (r338860) > > +++ head/lib/libc/Makefile Fri Sep 21 17:49:37 2018 (r338861) > > @@ -21,6 +21,11 @@ LIBC_ARCH=3D${MACHINE_ARCH} > > LIBC_ARCH=3D${MACHINE_CPUARCH} > > .endif > > =20 > > +.if (${LIBC_ARCH} =3D=3D amd64 || ${LIBC_ARCH} =3D=3D i386) && \ > > + defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} =3D=3D "" > > +.error ${LIBC_ARCH} libc requires linker ifunc support > > +.endif > > + > > # All library objects contain FreeBSD revision strings by default; the= y may be > > # excluded as a space-saving measure. To produce a library that does > > # not contain these strings, add -DSTRIP_FBSDID (see <sys/cdefs.h>) to= CFLAGS >=20 > It seems that this would break bootstraping from a FreeBSD -CURRENT > before ifunc? It does. The HardenedBSD nightly build server is running 11-STABLE and now cannot build 12-CURRENT: https://jenkins.hardenedbsd.org/jenkins/job/HardenedBSD-CURRENT-amd64/1332/= console Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --v2fua2r66qnkigtm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlumiMkACgkQaoRlj1JF bu7vbQ//WyCQmmEuwZxvHDvVk8gTp/nBA3d9HFt+dRmBcGTH3+KUh55wfNVT7tSZ OZ/jeODWrxXhT3o9/+cpq/UVaWvNuXJdys1EKd+LYaRQ38BJsXLOhVkfiTojUPb5 wjOjnIBmnnfh8VKgR67wUvprEVR+BO3b1CnYQnQXuSicIM+TVWAbXiWASuRinGDF 7T3xMpy9XWgYTkyAzibqabgidKemVjvVsylUQK+AWeF4ZcX3X37DB55NQW4kOcuc 5u6RnsrHf08Gyk66meOY0sVGrNfmHWq78kWZk4Bh6Xr7xQa7b+21wrFqycKD6AbN rwBozcDsWWkZNJ+r7Tt/qs00KShr5yPUlRkb0cYUi8Q/LUSBdqwLNkxmKlEnSiqs k1u25Yua2cpLLwO2Rouza4yMTdvsHXQpRD0Hjdo+gjTYXyofY1hWpXIBIexzcCZY IE19k5aH5M9Fr5dTtl0xOSuQMw4qjuJb0EtywZQeXwVe/AU/fCDCsPFQAla6nZ86 hD5kNCn9BGI09L888OQ3sHUAdgRyVnG1D0UsFGqnwOgORgBuuxNjlRIYZPP5w1Si gqy8aq72AEHeIsCDXrW/h+H2uGVU6s06hyYXTb+l5W0DbaDoHlyXxpFLLPsuDFzb TKgpZAPo8oi2HqRm01GTRane8RGQ17Aqtg5aJV7jgivDvmGzVug= =dSP/ -----END PGP SIGNATURE----- --v2fua2r66qnkigtm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180922182414.mrm5oavdjeu6bb3y>