Date: Sat, 23 Jul 2005 11:31:20 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/games/fortune/fortune fortune.c Message-ID: <20050723020120.GV842@wantadilla.lemis.com> In-Reply-To: <20050723015517.GA28428@nagual.pp.ru> References: <200507230146.j6N1koqL061690@repoman.freebsd.org> <20050723015517.GA28428@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--O7hm+SMpb/lu0d4d
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Saturday, 23 July 2005 at 5:55:17 +0400, Andrey A. Chernov wrote:
> On Sat, Jul 23, 2005 at 01:46:50AM +0000, Greg Lehey wrote:
>> grog 2005-07-23 01:46:50 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> games/fortune/fortune fortune.c
>> Log:
>> Use a random number to seed the random number generator. Goodby, Rush
>> Limbaugh.
>>
>> This should have already worked properly if random(4) has been
>> initialized correctly, but it seems that this is frequently not the
>> case. Instead, use the microsecond part of the current time as the
>> seed.
>
> It is already properly and truly randomly initialized, instead of
> any microseconds tricks.
Theoretically, yes, as I mentioned.
> Do you miss srandomdev(); here?
No, it was there:
init_prob();
- srandomdev();
+ gettimeofday (&now, NULL);
+ srandom (now.tv_usec);
But for whatever reasons, many systems seem to have incorrect
random(4) initialization. You'll recall the debate about removing
Rush Limbaugh fortunes recently because, for some reason related to
this issue, his fortunes kept popping up. This is the only place
where it seems to make any difference, so it's easier to use a
different seed.
Greg
--
The virus once contained in this message has lost interest in life,
shrivelled up and died. LEMIS anti-virus has given it an appropriate
burial.
For further details see http://www.lemis.com/grog/lemis-virus.html
Finger grog@FreeBSD.org for PGP public key.
See complete headers for address and phone numbers.
--O7hm+SMpb/lu0d4d
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQFC4aTwIubykFB6QiMRAtzNAJ4uI4pscGJfSIf9vR+yUtAIL4jDcACgmwVi
T+CPqGfKw5dAWdm/uL4mtxw=
=xx6A
-----END PGP SIGNATURE-----
--O7hm+SMpb/lu0d4d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050723020120.GV842>