Date: Fri, 23 Jan 2009 22:33:23 +0100 From: Lars Engels <lme@FreeBSD.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: current@freebsd.org, Hans Petter Selasky <hselasky@c2i.net> Subject: Re: [PATCH] for ng_ubt2 stalled transfers Message-ID: <20090123213323.GO60948@e.0x20.net> In-Reply-To: <20090123212952.GM60948@e.0x20.net> References: <bb4a86c70901231112x693f18cmbb29b966cb972992@mail.gmail.com> <bb4a86c70901231113v2b72423cg7aadbb7348d9bafe@mail.gmail.com> <20090123212952.GM60948@e.0x20.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--mPOSj6iWmtyhwOMz Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 23, 2009 at 10:29:52PM +0100, Lars Engels wrote: > On Fri, Jan 23, 2009 at 11:13:59AM -0800, Maksim Yevmenkin wrote: > > On Fri, Jan 23, 2009 at 11:12 AM, Maksim Yevmenkin > > <maksim.yevmenkin@gmail.com> wrote: > > > Lars, > > > > > >> Maksim has made a lot of changes to the Bluetooth driver. Maybe he c= an look > > >> into it? > > >> > > >> This looks like a NULL-pointer access to me. > > >> > > >> Maksim: > > >> > > >> In the ubt_detach routine, make sure that: > > >> > > >> 0) No further commands are accepted from the Netgraph stack. > > >> 1) You drain the task queue! > > >> 2) You drain all USB transfers: "usb2_transfer_drain()" called unloc= ked. > > >> 3) Set the "sc_node" to NULL. > > > > > > please try attached patch for ng_ubt2 that hopefully addresses some of > > > the issues with stalled transfers. stalled transfers do not happen on > > > my machine, so i can not test it. i briefly kicked the tires and made > > > sure other things seems to work fine for me. > >=20 > > sorry, forgot to attach the patch :) > >=20 > > thanks, > > max >=20 > Thanks for the quick patch, but that did not help: >=20 > ubt0: <Broadcom Corp Foxconn Bluetooth 2.0 plus EDR, class 224/1, rev 2.0= 0/1.00, addr 2> on usbus2 > ubt0:ubt_bulk_read_callback:981: bulk-in transfer failed: USB_ERR_STALLED > ubt0:ubt_intr_read_callback:834: interrupt transfer failed: USB_ERR_STALL= ED >=20 >=20 > I also have another usb bluetooth stick which shows this on insertion: >=20 > Jan 23 22:13:00 maggie kernel: usb2_alloc_device:1401: set address 2 fail= ed (ignored) > Jan 23 22:13:00 maggie kernel: usb2_alloc_device:1436: getting device des= criptor at addr 2 failed! > Jan 23 22:13:01 maggie kernel: ugen0.2: <Cambridge Silicon Radio> at usbu= s0 > Jan 23 22:13:01 maggie kernel: ubt1: <Cambridge Silicon Radio Bluetooth U= SB dongle, class 224/1, rev 1.10/3.73, addr 2> on usbus0 > I forgot to mention that both bt devices worked without problems with the old stack, so there is no hardware issue. :) --mPOSj6iWmtyhwOMz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkl6N6MACgkQKc512sD3afg6uACdHPrrIKefFoYD8I5gg6tioj0R hUwAoMCIRxLDQEzpRgvRqXg+04p0TLl9 =vbBR -----END PGP SIGNATURE----- --mPOSj6iWmtyhwOMz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090123213323.GO60948>