Date: Thu, 15 Nov 2007 18:33:12 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: rwatson@FreeBSD.org Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, glebius@FreeBSD.org, julian@elischer.org, sgk@troutmask.apl.washington.edu Subject: Re: cvs commit: src/sys/kern kern_kse.c Message-ID: <20071115.183312.619299480.imp@bsdimp.com> In-Reply-To: <20071115194710.L82897@fledge.watson.org> References: <20071115181401.GA17094@troutmask.apl.washington.edu> <473C901F.1080906@elischer.org> <20071115194710.L82897@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20071115194710.L82897@fledge.watson.org>
Robert Watson <rwatson@FreeBSD.org> writes:
:
: On Thu, 15 Nov 2007, Julian Elischer wrote:
:
: >>> "no matter how small the change, use diff + patch to move it across."
: >>
: >> After applying the patch on your commit machine, is it too difficult to
: >> actually retest before committing? This would catch the broken commit
: >> before it becomes a Tinderbox issue.
: >>
: >> Seems to be a QA problem on your part.
: >
: > yes.. but I can't do a compile from my mac. (my commit machine). The answer
: > is to be rigorous about how I move the patch from the build machine to the
: > commit machine.
: >
: > This is a temporary situation. new infrastructure will let me commit from my
: > build machine again.
:
: I find having a copy of Parallels (or VMWare) around very useful for precisely
: this situation -- it means that even when I have only the Mac around I can
: easily do a local test build. The various VM packages certainly have their
: limitations, but they're far better than nothing.
I've always found that no matter how much testing i do, sometimes
accidents happen. The only way to be sure is to test, commit and then
checkout in a clean tree the change you made and test again...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071115.183312.619299480.imp>