Date: Sat, 12 Jan 2013 16:05:55 +0000 (UTC) From: Steven Hartland <smh@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r245334 - head/sys/dev/e1000 Message-ID: <201301121605.r0CG5tcd084026@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: smh Date: Sat Jan 12 16:05:55 2013 New Revision: 245334 URL: http://svnweb.freebsd.org/changeset/base/245334 Log: Fixed mbuf free when receive structures fail to allocate. This prevents quad igb card on high core machines, without any nmbcluster or igb queue tuning wedging the boot process if all nics are configured. Reviewed by: jfv Approved by: pjd (mentor) MFC after: 1 week Modified: head/sys/dev/e1000/if_igb.c Modified: head/sys/dev/e1000/if_igb.c ============================================================================== --- head/sys/dev/e1000/if_igb.c Sat Jan 12 16:01:58 2013 (r245333) +++ head/sys/dev/e1000/if_igb.c Sat Jan 12 16:05:55 2013 (r245334) @@ -4330,8 +4330,8 @@ fail: * the rings that completed, the failing case will have * cleaned up for itself. 'i' is the endpoint. */ - for (int j = 0; j > i; ++j) { - rxr = &adapter->rx_rings[i]; + for (int j = 0; j < i; ++j) { + rxr = &adapter->rx_rings[j]; IGB_RX_LOCK(rxr); igb_free_receive_ring(rxr); IGB_RX_UNLOCK(rxr);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301121605.r0CG5tcd084026>