Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 16 May 2024 14:18:54 -0700
From:      Yuri <yuri@FreeBSD.org>
To:        Vladimir Druzenko <vvd@freebsd.org>, Yuri <yuri@FreeBSD.org>, Tobias Kortkamp <tobik@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 5c97fbea8cb6 - main - *: Spell PORTREVISION correctly
Message-ID:  <681c0653-fead-4825-8451-7723c38882e2@FreeBSD.org>
In-Reply-To: <20db6508-cbba-409d-aaec-fdeb5d7e5a5d@freebsd.org>
References:  <202405131305.44DD5p58063913@gitrepo.freebsd.org> <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org> <1210af6d-2598-46d4-8115-ec2f2a5399fd@FreeBSD.org> <20db6508-cbba-409d-aaec-fdeb5d7e5a5d@freebsd.org>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
On 5/16/24 14:02, Vladimir Druzenko wrote:
>
> Why not?

1. It would add a lot of unnecessary lines to Makefiles.
2. It is possible to check for such typos in git commit scripts and 
prevent bad commits like this.
3. portlint also checks for this.
4. It's not a wide-spread problem. Just identify who added typos and 
send them educational materials about Tools/scripts/bump-revision.sh, 
portlint, etc.



Yuri


[-- Attachment #2 --]
<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix"><font face="monospace">On 5/16/24
        14:02, Vladimir Druzenko wrote:<br>
      </font></div>
    <blockquote type="cite"
      cite="mid:20db6508-cbba-409d-aaec-fdeb5d7e5a5d@freebsd.org">
      <blockquote type="cite"
        cite="mid:1210af6d-2598-46d4-8115-ec2f2a5399fd@FreeBSD.org"> </blockquote>
      <font face="monospace"><br>
        Why not?</font></blockquote>
    <font face="monospace"><br>
      1. It would add a lot of unnecessary lines to Makefiles.<br>
      2. It is possible to check for such typos in git commit scripts
      and prevent bad commits like this.<br>
      3. portlint also checks for this.<br>
      4. It's not a wide-spread problem. Just identify who added typos
      and send them educational materials about <span
        style="color:#000000;background-color:#ffffff;">Tools/scripts/bump-revision.sh,
        portlint, etc.</span><br>
    </font><br>
    <br>
    <br>
    Yuri
    <p><br>
    </p>
  </body>
</html>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?681c0653-fead-4825-8451-7723c38882e2>