Date: Mon, 21 Mar 2016 14:52:38 -0600 From: Warner Losh <imp@bsdimp.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297136 - head/sys/conf Message-ID: <4D26F4EE-A51F-44E1-B66C-4498FA029C6F@bsdimp.com> In-Reply-To: <20160321203528.GC1254@FreeBSD.org> References: <201603210551.u2L5pL1X037311@repo.freebsd.org> <20160321203528.GC1254@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 21, 2016, at 2:35 PM, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > > On Mon, Mar 21, 2016 at 05:51:21AM +0000, Adrian Chadd wrote: > A> Author: adrian > A> Date: Mon Mar 21 05:51:21 2016 > A> New Revision: 297136 > A> URL: https://svnweb.freebsd.org/changeset/base/297136 > A> > A> Log: > A> Remove from NOTES - it's built as a module now. > > You are doing wrong. A driver must be buildable as a module and > statically as well. > > It is legitimate to remove from GENERIC, but not from NOTES. In private conversations with Adrian, he indicated that he’s about to reorganize this driver substantially. He’ll make sure it works during the record period as a module, but can’t guarantee he won’t break building it into the kernel. So he took it out from here so that the LINT build doesn’t break. He intends to reconnect it once he’s done with the rearrangement. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJW8F8XAAoJEGwc0Sh9sBEAFt8P/2LU1mBtmZqPghy1F8eyq1FG evVF6HbdxCj5VwnU0nXA/s7mN7nUoOCpHqPan+jDAzZuNaxY4WNDkffGLoHXs0aF o7nu75XaPn8Ll7r/LmbyqfO7IRHlNyk2wZ2oa9Ndj7YB3OYH1DXrfL2e0R8t8RIp +6AkcKnEMRbdZRFg7iaEtwdhpG4CWMqEDLs2MnNDzooEOEsbkY2hXyWD5urgAyWd ZN9wi2Y5HEAfqaRhPgzquo5FdwwCkqiXU9A8SPMTw1fS3ifAE8rjybHwWgGR8vBm eDZp0ghj2BihLhteyDEoCXEuvVF38s6x1+7OY7qGhgLuKY48ggahMy9KtwmNuD/7 macHNXXH6bbns9vq/ehSTFq1+/MvZvOMvxhLYw84Xr/vkukA5kz1aiTqXzTK2mTm HzG6YtiA9F/FIR97S98z8w8H6atHOA+Rdeg7BwhsMI6ze+8RbeEvc83FLo15XPka hKcc7b9dXb3xOEJWKrD08Ut7ULnq02ALrFPH7IHHjxFaNSGdZRuD7urBHmaaTkfL 6R5Ia3wkxQ1lPtXpG8K2ARDmi09q1xxoxN62jsRydI9NNDC37nkMjLovgbDWXJ1K NHfv6b9W7xQKaeLhw8vCBjblW606LXsFJe9bjNTwXf6U9CFFPtM2vMyKsGGF+3WL nLlfo9ni+g6Ff7LShsNw =WpXH -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D26F4EE-A51F-44E1-B66C-4498FA029C6F>