Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Nov 2005 12:43:43 +0100
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        Todd Miller <millert@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 86437 for review
Message-ID:  <20051108114343.GA10509@garage.freebsd.pl>
In-Reply-To: <200511072145.jA7Lj66J026949@repoman.freebsd.org>
References:  <200511072145.jA7Lj66J026949@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 07, 2005 at 09:45:06PM +0000, Todd Miller wrote:
+> http://perforce.freebsd.org/chv.cgi?CH=3D86437
+>=20
+> Change 86437 by millert@millert_ibook on 2005/11/07 21:44:18
+>=20
+> 	fix typo introduced in previous rev
+>=20
+> Affected files ...
+>=20
+> .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_a=
v.c#6 edit
+>=20
+> Differences ...
+>=20
+> =3D=3D=3D=3D //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin=
/ss/mach_av.c#6 (text+ko) =3D=3D=3D=3D
+>=20
+> @@ -82,7 +82,7 @@
+>  	if (mcl =3D=3D NULL)
+>  		return 0;
+> =20
+> -	cl =3D msgid-mcl->baseid / (8 * sizeof(access_vector_t));
+> +	cl =3D (msgid-mcl - >baseid) / (8 * sizeof(access_vector_t));

That's a hard to read line of code:)
I think this is a bit easier:

	cl =3D (msgid - mcl->baseid) / (8 * sizeof(access_vector_t));

I suppose this was the plan, but you inserted spaces in the wrong place.

--=20
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

--6TrnltStXW4iwmi0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFDcI9uForvXbEpPzQRAmuuAJ9hdLuPHZYcCDe0qGL3Bup9AU72RgCggQwu
nYuIEnMYE1yRTfUPTrap8Ew=
=OWHF
-----END PGP SIGNATURE-----

--6TrnltStXW4iwmi0--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051108114343.GA10509>