Date: Tue, 8 Nov 2005 12:43:43 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Todd Miller <millert@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 86437 for review Message-ID: <20051108114343.GA10509@garage.freebsd.pl> In-Reply-To: <200511072145.jA7Lj66J026949@repoman.freebsd.org> References: <200511072145.jA7Lj66J026949@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Nov 07, 2005 at 09:45:06PM +0000, Todd Miller wrote: +> http://perforce.freebsd.org/chv.cgi?CH=86437 +> +> Change 86437 by millert@millert_ibook on 2005/11/07 21:44:18 +> +> fix typo introduced in previous rev +> +> Affected files ... +> +> .. //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#6 edit +> +> Differences ... +> +> ==== //depot/projects/trustedbsd/sedarwin7/src/sedarwin/sedarwin/ss/mach_av.c#6 (text+ko) ==== +> +> @@ -82,7 +82,7 @@ +> if (mcl == NULL) +> return 0; +> +> - cl = msgid-mcl->baseid / (8 * sizeof(access_vector_t)); +> + cl = (msgid-mcl - >baseid) / (8 * sizeof(access_vector_t)); That's a hard to read line of code:) I think this is a bit easier: cl = (msgid - mcl->baseid) / (8 * sizeof(access_vector_t)); I suppose this was the plan, but you inserted spaces in the wrong place. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDcI9uForvXbEpPzQRAmuuAJ9hdLuPHZYcCDe0qGL3Bup9AU72RgCggQwu nYuIEnMYE1yRTfUPTrap8Ew= =OWHF -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051108114343.GA10509>