Date: Tue, 22 May 2007 22:13:36 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Dag-Erling Sm??rgrav <des@des.no> Cc: Joe Marcus Clarke <marcus@FreeBSD.org>, "current@freebsd.org" <current@FreeBSD.org> Subject: Re: [Fwd: Serious problem with mount(8)] Message-ID: <20070522201336.GA4201@garage.freebsd.pl> In-Reply-To: <864pm4zkre.fsf@dwp.des.no> References: <46534301.10005@FreeBSD.org> <864pm4zkre.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 22, 2007 at 10:05:57PM +0200, Dag-Erling Sm??rgrav wrote: > Joe Marcus Clarke <marcus@FreeBSD.org> writes: > > I really don't know why I didn't notice this before, but when mount was > > converted to use the pidfile(3) API three months ago, the behavior of > > mount(8) changed with regard to restarting mountd. A pidfile client > > cannot use pidfile_open(3) as this will truncate the pidfile. The > > result is that mount reads in a PID of 0, and when it tries to send a > > SIGHUP to this PID, it kills itself. Consequently, this is breaking the > > ports Tinderbox. > > > > I suppose we could revert to the previous behavior, but use flopen() to > > test if the file is actually locked. Maybe something like this: > > > > http://www.marcuscom.com/downloads/mount.c.diff >=20 > Better yet, extend the pidfile API with a function which reads the > contents of a PID file and also checks whether it's locked. That would be useful also for pkill(1). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGU07wForvXbEpPzQRApoEAKDYPRk6Rih7K7kn8JsFzhp9zquXaACg6Un9 CGw9Z6QwQqR0fZEdL35k+mw= =Hrmo -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070522201336.GA4201>