Date: Tue, 26 Sep 2017 11:13:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 222620] [patch] usr.sbin/ppp/auth.c: Incorrect NOPAM section in auth_CheckPasswd Message-ID: <bug-222620-8@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222620 Bug ID: 222620 Summary: [patch] usr.sbin/ppp/auth.c: Incorrect NOPAM section in auth_CheckPasswd Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: bouceklubos@gmail.com Keywords: patch Created attachment 186736 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=186736&action=edit auth.c patch Hello, In my opinion, the current code in usr.sbin/ppp/auth.c:auth_CheckPasswd (NOPAM section) is incorrect: - pw is not initialized before use, - success is returned if crypt(3) returns error (NULL). I'm attaching a patch, please review. Regards, Lubos Boucek -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222620-8>