Date: Tue, 31 Oct 2023 12:15:16 +0000 From: "John F Carr" <jfc@mit.edu> To: Alexander Leidinger <alexleidingerde@gmail.com> Cc: "freebsd-fs@freebsd.org" <freebsd-fs@freebsd.org> Subject: Re: ZFS txg rollback: expected timeframe? Message-ID: <18B0B6B6-9237-42D0-9FB2-D55CE72E1CCA@mit.edu> In-Reply-To: <CAJg7qzHONfMeLUm20OE6Jo5uFLt9bY5VVhbY8z%2BoEVcHYwyoXw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Oct 31, 2023, at 06:16, Alexander Leidinger <alexleidingerde@gmail.com> wrote: > > Issue: a overheating CPU may have corrupted a zpool (4 * 4TB in raidz2 setup) in a way that a normal import of the pool panics the machine with "VERIFY3(l->blk_birth == r->blk_birth) failed (101867360 == 101867222)". > I disabled that assertion because it gives a false alarm with some combinaion of deduplication, cloning, and snapshotting on one of my systems. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261538 https://github.com/openzfs/zfs/issues/11480 [-- Attachment #2 --] commit 3a99d614766de85d13789abb2e19175c4666d260 Author: John F. Carr <jfc@mit.edu> Date: Fri Sep 8 14:13:00 2023 -0400 Disable incorrect ZFS assertion diff --git a/sys/contrib/openzfs/module/zfs/dsl_deadlist.c b/sys/contrib/openzfs/module/zfs/dsl_deadlist.c index 9827eb14728d..7fea12ab52c5 100644 --- a/sys/contrib/openzfs/module/zfs/dsl_deadlist.c +++ b/sys/contrib/openzfs/module/zfs/dsl_deadlist.c @@ -999,8 +999,10 @@ livelist_compare(const void *larg, const void *rarg) /* if vdevs are equal, sort by offsets. */ uint64_t l_dva0_offset = DVA_GET_OFFSET(&l->blk_dva[0]); uint64_t r_dva0_offset = DVA_GET_OFFSET(&r->blk_dva[0]); +#if 0 /* see bug 261538 and https://github.com/openzfs/zfs/issues/11480 */ if (l_dva0_offset == r_dva0_offset) ASSERT3U(l->blk_birth, ==, r->blk_birth); +#endif return (TREE_CMP(l_dva0_offset, r_dva0_offset)); }help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18B0B6B6-9237-42D0-9FB2-D55CE72E1CCA>