Date: Mon, 24 Apr 2017 23:55:18 +0200 From: Marius Strobl <marius@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r439345 - in head/sysutils/cdrdao: . files Message-ID: <20170424215518.GC15359@alchemy.franken.de> In-Reply-To: <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org> References: <201704242023.v3OKNN8q058653@repo.freebsd.org> <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 24, 2017 at 03:37:29PM -0600, Adam Weinberger wrote: > > On 24 Apr, 2017, at 14:23, Marius Strobl <marius@FreeBSD.org> wrote: > > > > Author: marius > > Date: Mon Apr 24 20:23:23 2017 > > New Revision: 439345 > > URL: https://svnweb.freebsd.org/changeset/ports/439345 > > > > Log: > > - Move the inclusion of bsd.port.pre.mk up slightly so ${UNAME} is also > > available in the gcdmaster slave port at the required point in time > > (it's unclear why this was no problem with the cdrdao port before). [1] > > Because you didn't add the != until r439255. Using != is almost always a bad thing in a port Makefile. No, the != in r439255 worked for sysutils/cdrdao, but not for its sysutils/gcdmaster slave. > Why aren't you using ${ARCH}? Because ${ARCH} translates to `uname -p` and what's needed here is the output of `uname -m`. Depending on the architecture FreeBSD is running on, both outputs are the same or differ. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170424215518.GC15359>