Date: Sun, 24 Feb 2008 11:07:29 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Colin Percival <cperciva@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <20080224110613.X25292@fledge.watson.org> In-Reply-To: <200802240007.m1O071xr052282@repoman.freebsd.org> References: <200802240007.m1O071xr052282@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 24 Feb 2008, Colin Percival wrote: > cperciva 2008-02-24 00:07:00 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_syscalls.c > Log: > After finishing sending file data in sendfile(2), don't forget to send > the provided trailers. This has been broken since revision 1.240. Nice work tracking this down -- it sounds like the perfect candidate for a regression test. Over the last year or two, we've been working hard to populate src/tools/regression/sockets with various test cases, and it sounds like the sendfile tests there could use some fleshing out, since we've now seen several rather significant functional regressions over the last few years. Any chance we can get you to take a look at doing that as well? :-) Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080224110613.X25292>