Date: Thu, 4 Jun 2015 18:18:03 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: NGie Cooper <yaneurabeya@gmail.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r283974 - head/lib/libugidfw Message-ID: <CAOfEmZhZYLoqp2dKg_y_sU_VN4dfG_m9EpmkV8PQyiatymgyhg@mail.gmail.com> In-Reply-To: <CAGHfRMBdY_LVqJXTbH9=4LkS2_KaajiMEeFcAOp80Yhes-bDbQ@mail.gmail.com> References: <201506040244.t542ibW9051338@svn.freebsd.org> <20150604074152.GZ2499@kib.kiev.ua> <CAGHfRMBdY_LVqJXTbH9=4LkS2_KaajiMEeFcAOp80Yhes-bDbQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2015-06-04 16:29 GMT+08:00 NGie Cooper <yaneurabeya@gmail.com>: > On Thu, Jun 4, 2015 at 12:41 AM, Konstantin Belousov > <kostikbel@gmail.com> wrote: > ... > >> - size = sizeof(rule); > >> error = sysctl(name, len, NULL, NULL, &rule, 0); > > This is very strange chunk. I suspect that the intent was to have 'size' > > as the sixth argument to the sysctl(3) call, or just have sizeof(rule) > > instead of 0. > > Agreed. > Agreed too, I have open another review request, because I have double check and there are some missing prototypes too. Best, -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZhZYLoqp2dKg_y_sU_VN4dfG_m9EpmkV8PQyiatymgyhg>