Date: Tue, 14 Sep 2010 20:29:36 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: dougb@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212558 - head/usr.bin Message-ID: <20100914.202936.19192035460743630.imp@bsdimp.com> In-Reply-To: <4C9020C5.90108@FreeBSD.org> References: <201009131530.o8DFU9f5010734@svn.freebsd.org> <4C9020C5.90108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4C9020C5.90108@FreeBSD.org>
Doug Barton <dougb@FreeBSD.org> writes:
: On 9/13/2010 8:30 AM, Warner Losh wrote:
: > Author: imp
: > Date: Mon Sep 13 15:30:09 2010
: > New Revision: 212558
: > URL: http://svn.freebsd.org/changeset/base/212558
: >
: > Log:
: > Move to using Makefile.arch to include the proper target-specific
: > programs.
: >
: > Modified:
: > head/usr.bin/Makefile
: >
: > Modified: head/usr.bin/Makefile
: > ==============================================================================
: > --- head/usr.bin/Makefile Mon Sep 13 15:19:49 2010 (r212557)
: > +++ head/usr.bin/Makefile Mon Sep 13 15:30:09 2010 (r212558)
: > @@ -11,48 +11,29 @@
: >
: > SUBDIR= alias \
: > apply \
: > - ${_ar} \
:
: > .if ${MK_TOOLCHAIN} != "no"
: > -_ar= ar
:
: > +SUBDIR+= ar
:
:
: I'm curious about why you're changing the method we use to switch
: optional elements. The change seems gratuitous to me, but I'm willing
: to be persuaded.
I posted these exact patches many times to arch@ and while people
commented on other aspects of the change, no body ever commented on
this aspect of the change (apart from comments about how to do it
better). That's why I specifically said that there was no objection
from arch@ for these changes.
Doing things this way makes it easier for different architectures to
subset or augment the directories to build (and it makes it a lot
easier to know what's built on a given architecture). They can be
concentrated into individual Makefiles that are easier to select on.
MIPS and ARM are both moving to having multiple names (powerpc moved a
couple of months ago) and the current arrangement doesn't scale well
in the face of these changes. It is far from gratuitous.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100914.202936.19192035460743630.imp>