Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Apr 2018 00:51:55 -0400
From:      Allan Jude <allanjude@freebsd.org>
To:        Mark Johnston <markj@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r332365 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <33ea9236-2442-10d6-95d0-9e4d33c4613e@freebsd.org>
In-Reply-To: <201804101356.w3ADu6Jr072766@repo.freebsd.org>
References:  <201804101356.w3ADu6Jr072766@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Bv5MZTSXhBrZQG7Ah1pQNP4qbfe0jggFx
Content-Type: multipart/mixed; boundary="NbJClafTHxD5uEnny03GpV5P87esparfL";
 protected-headers="v1"
From: Allan Jude <allanjude@freebsd.org>
To: Mark Johnston <markj@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <33ea9236-2442-10d6-95d0-9e4d33c4613e@freebsd.org>
Subject: Re: svn commit: r332365 -
 head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
References: <201804101356.w3ADu6Jr072766@repo.freebsd.org>
In-Reply-To: <201804101356.w3ADu6Jr072766@repo.freebsd.org>

--NbJClafTHxD5uEnny03GpV5P87esparfL
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 2018-04-10 09:56, Mark Johnston wrote:
> Author: markj
> Date: Tue Apr 10 13:56:06 2018
> New Revision: 332365
> URL: https://svnweb.freebsd.org/changeset/base/332365
>=20
> Log:
>   Set zfs_arc_free_target to v_free_target.
>  =20
>   Page daemon output is now regulated by a PID controller with a setpoi=
nt
>   of v_free_target. Moreover, the page daemon now wakes up regularly
>   rather than waiting for a wakeup from another thread. This means that=

>   the free page count is unlikely to drop below the old
>   zfs_arc_free_target value, and as a result the ARC was not readily
>   freeing pages under memory pressure. Address the immediate problem by=

>   updating zfs_arc_free_target to match the page daemon's new behaviour=
=2E
>  =20
>   Reported and tested by:	truckman
>   Discussed with:	jeff
>   X-MFC with:	r329882
>   Differential Revision:	https://reviews.freebsd.org/D14994
>=20

On a somewhat unrelated note, can we rename this sysctl and change to be
counted in bytes? When users are tuning ZFS, every other ZFS value is in
bytes, not pages.

Maybe keep the currently variable as it is, in pages, and adjust it by
dividing the user set value by the page size.

The current name is great, but I wouldn't want anyone to end up setting
it to 4096x the value they actually want if we just changed it out from
under them.

--=20
Allan Jude


--NbJClafTHxD5uEnny03GpV5P87esparfL--

--Bv5MZTSXhBrZQG7Ah1pQNP4qbfe0jggFx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQIcBAEBAgAGBQJazZRvAAoJEBmVNT4SmAt+fDoQAOjY4MAP17oUWGUo0zgfqWww
Yt2f2TUwzB5p61EscwIkhUo/4LalQWihnkm3EM0jF7piiaa+Kzei0aWX0Ky4Adv+
mcfU8CYbOakvqJ6PpxEBK0NZGkzTETCzLRxBA0RDtZnZJW4GddwuACp1D7LZHl5e
TbFh0kWETs9kt/ADxPbjIMfyRUoxyh1bVnR4eeSTRHF/uuB2chmrVxTJBTG0kVU8
t2VpvefRee1X1XPJNKKIqOSsWLiN/VaEljEcwRmPTy/LDwLCxOnwkbMs0mFFOm71
OzZerSIMUI3e7irhQB9DDtyY5I98aybCKpEQqC8ctzRyaGVOhcNxuprLy5+w4UUO
SvOkHMebMSOMxtgSjxJZYyy3b43CSggTXMtWQVVvdSI0++gz9RhtTy4diqF32oXq
N9jOiWPn9J9cvjiKYai+SCwQoHrAFXPx+/SdVMuRu1+81nwFD8MAVzitlpxBK6XS
mh6pBDIVOycqeGbiswMl2RT60n2AgazWHameR/mo27nWm0m5hqMV2MynjvIEVMOv
YIdta3DYUVcdSTCt/jbr2HdsL+M34U/7q5A1MT5NoI1y6NGLk2JLEORa+EdljxHt
2M53vBZgW8712Jj5p34+z/+PPSzbkKDfpR6M6bD3fmqgC73/oHCDR/JkDB+oNAGc
PO23nvJNRT89ukWXiw1q
=X8iN
-----END PGP SIGNATURE-----

--Bv5MZTSXhBrZQG7Ah1pQNP4qbfe0jggFx--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33ea9236-2442-10d6-95d0-9e4d33c4613e>