Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Mar 2003 22:15:01 +1100
From:      Tim Robbins <tjr@FreeBSD.org>
To:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/stdio vfwprintf.c
Message-ID:  <20030313221501.A64319@dilbert.robbins.dropbear.id.au>
In-Reply-To: <20030313104157.GA13413@HAL9000.homeunix.com>; from das@FreeBSD.ORG on Thu, Mar 13, 2003 at 02:41:57AM -0800
References:  <200303130549.h2D5n9m2093851@repoman.freebsd.org> <20030313104157.GA13413@HAL9000.homeunix.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 13, 2003 at 02:41:57AM -0800, David Schultz wrote:

> > tjr         2003/03/12 21:49:09 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     lib/libc/stdio       vfwprintf.c 
> >   Log:
> >   MFp4: Catch up to recent __dtoa() interface changes and removal of cvt()'s
> >   last argument.
> >   
> >   Revision  Changes    Path
> >   1.5       +10 -11    src/lib/libc/stdio/vfwprintf.c
> 
> Thanks for remembering that.  I know this has been discussed
> before, but will vfwprintf() ever be merged with vfprintf()?
> I'd rather not fix all the floating point bugs in what seems
> to be essentially two copies of the same code.

It's quite possible. I did create a merged version at one stage before
committing it, but thought it would be slightly easier to develop if
I didn't have to worry about the #ifdefs etc. Now that vfwprintf() is
pretty much finished, merging them mightn't be a bad idea. When I find a
decent chunk of spare time, I'll make a merged version again and send it
around for people to decide whether they like it more than the two separate
copies.

FWIW, merging your changes from vfprintf.c to vfwprintf.c was a matter of
doing:
p4 integ -f vfprintf.c#23,23 vfwprintf.c
p4 resolve vfwprintf.c
*fix 5 conflicts*
p4 submit vfwprintf.c

Most of the conflicts were caused by the removal of the last argument
to cvt() and moving the prototype for __dtoa().

Anyway, don't let the existence of vfwprintf.c put you off fixing bugs
in vfprintf.c. Until (if?) the files get merged, I'll take care of
propagating your changes to vfwprintf.


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030313221501.A64319>