Date: Wed, 27 Aug 2025 08:01:49 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: ShengYi Hung <aokblast@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2b74ff5fceb6 - main - ichwd: introduce i6300esbwd watch dog driver Message-ID: <55sn92r5-n62o-61s0-1s88-s2085o20q645@SerrOFQ.bet> In-Reply-To: <202508251545.57PFjqtI092750@gitrepo.freebsd.org> References: <202508251545.57PFjqtI092750@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Aug 2025, ShengYi Hung wrote: > The branch main has been updated by aokblast: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2b74ff5fceb6623f6114ce39baee9f6ec5f79277 > > commit 2b74ff5fceb6623f6114ce39baee9f6ec5f79277 > Author: ShengYi Hung <aokblast@FreeBSD.org> > AuthorDate: 2025-08-22 14:55:45 +0000 > Commit: ShengYi Hung <aokblast@FreeBSD.org> > CommitDate: 2025-08-25 15:45:24 +0000 > > ichwd: introduce i6300esbwd watch dog driver > > The intel 6300ESB watchdog is a special ICH-based watchdog device with a > different interface. > QEMU implements this watchdog for x86 systems. > > This change enables watchdog mode (rather than free-running mode) and > introduces 1 sysctl: > - hw.i6300esbwd.0.locked: locks the watchdog register after the event is > triggered, preventing it from being disabled until a hard reset. > > This feature has been tested on a Vultr AMD guest machine and local qemu > machine. > > PR: 259673 > Approved by: markj (mentor), lwhsu (mentor) > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D52049 > --- > sys/conf/files.x86 | 1 + > sys/dev/ichwd/i6300esbwd.c | 245 +++++++++++++++++++++++++++++++++++++++++++++ > sys/dev/ichwd/i6300esbwd.h | 46 +++++++++ > sys/dev/ichwd/ichwd.c | 2 +- > sys/dev/ichwd/ichwd.h | 3 +- > sys/modules/ichwd/Makefile | 2 +- > 6 files changed, 296 insertions(+), 3 deletions(-) Compiling GENERIC I see: /sys/dev/ichwd/i6300esbwd.c:49:1: warning: unused function 'i6300esbwd_cfg_read' [-Wunused-function] 49 | i6300esbwd_cfg_read(struct i6300esbwd_softc *sc) | ^~~~~~~~~~~~~~~~~~~ Is it needed or can it be removed? -- Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55sn92r5-n62o-61s0-1s88-s2085o20q645>