Date: Tue, 26 Aug 2014 15:15:31 -0400 From: John Baldwin <jhb@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: Harald Schmalzbauer <h.schmalzbauer@omnilan.de>, FreeBSD CURRENT <freebsd-current@freebsd.org>, "net@freebsd.org" <net@freebsd.org>, current@freebsd.org, Yuri <yuri@rawbw.com> Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) Message-ID: <201408261515.32146.jhb@freebsd.org> In-Reply-To: <CAOtMX2gkUBPOc4o4qRbUTdv_YOiQOVDuxXBkQZEAiez6i07NAg@mail.gmail.com> References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> <CAOtMX2gkUBPOc4o4qRbUTdv_YOiQOVDuxXBkQZEAiez6i07NAg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin <jhb@freebsd.org> wrote: > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: > >> Bez=C3=BCglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): > >> > Please check in this patch: > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D181741 > >> > Please MFC into 9.X > >> > > >> > Description of the problem is within PR. > >> > > >> > Thanks, > >> > Yuri > >> > >> Hello, > >> > >> I guess this fix should make it into 10.1. > >> Can someone check please? > > > > A fix has to make into HEAD first. I've cc'd Alan who responded to the= bug. > > Alan, note that glebius@ already committed the test case to HEAD a whil= e ago. >=20 > First, Gleb's testcase needs to be converted to ATF. This would be a > good exercise for anybody who's new to ATF and wants some practice. > Anybody interested? While that would be nice, I don't know that it's quite fair to require the test to be converted before working on a possible fix. The existing test doesn't seem that hard to run by hand: % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ % make =2E.. % > ./unix_passfd=20 beginning test1-simplesendfd test1-simplesendfd passed =2E.. beginning test8-rigths+creds+payload unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received I only say this because in the bug followup you seemed to have described a possible solution so it seems that you would be able to develop a fix quick= er than other folks since you are already familiar with the issues involved. (Also, you've fixed other related issues recently.) =2D-=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201408261515.32146.jhb>