Date: Tue, 19 Sep 2006 11:12:16 +0300 From: Alex Lyashkov <umka@sevcity.net> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-hackers@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: jail2 patchset 12 Message-ID: <1158653536.3213.5.camel@berloga.shadowland> In-Reply-To: <200609181750.58145.jhb@freebsd.org> References: <1158407656.3215.33.camel@berloga.shadowland> <20060917211905.GA64182@xor.obsecurity.org> <1158530904.3213.1.camel@berloga.shadowland> <200609181750.58145.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
thanks for point this :( i will rewrite old jail api as wrapper to new
API for avoid similar errors...
=F7 =F7=D4=D2, 19.09.2006, =D7 00:50, John Baldwin =D0=C9=DB=C5=D4:
> On Sunday 17 September 2006 18:08, Alex Lyashkov wrote:
> > Thanks for you report. I really more test new jail2 API then old :(
> > Please apply this patch.
> >=20
> > # p4 diff -du kern_jail.c
> > =3D=3D=3D=3D //depot/projects/jail2/sys/kern/kern_jail.c#4 -
> > /root/jail2/sys/kern/kern_jail.c =3D=3D=3D=3D
> > @@ -316,6 +316,7 @@
> > if (error)
> > return (error);
> >=20
> > + mtx_lock(&allprison_mtx);
> > pr =3D prison_find(uap->jid);
> > if (pr =3D=3D NULL) {
> > return (ESRCH);
>=20
> Does this leak the lock in the ESRCH case now?
> =20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1158653536.3213.5.camel>