Date: Tue, 21 Apr 2009 13:37:36 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: raj@semihalf.com Cc: stas@FreeBSD.org, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191322 - in head/sys: arm/conf dev/iicbus Message-ID: <20090421.133736.1374096586.imp@bsdimp.com> In-Reply-To: <BF74CD94-FEE3-4B7E-823D-245296A3A085@semihalf.com> References: <20090421223502.507f0dcf.stas@FreeBSD.org> <20090421.123847.70203894.imp@bsdimp.com> <BF74CD94-FEE3-4B7E-823D-245296A3A085@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <BF74CD94-FEE3-4B7E-823D-245296A3A085@semihalf.com>
Rafal Jaworowski <raj@semihalf.com> writes:
:
: On 2009-04-21, at 20:38, M. Warner Losh wrote:
:
: > In message: <20090421223502.507f0dcf.stas@FreeBSD.org>
: > Stanislav Sedov <stas@FreeBSD.org> writes:
: > : -----BEGIN PGP SIGNED MESSAGE-----
: > : Hash: SHA1
: > :
: > : On Tue, 21 Apr 2009 12:18:05 -0600 (MDT)
: > : "M. Warner Losh" <imp@bsdimp.com> mentioned:
: > :
: > : > In message: <20090421220138.f6e7b4d4.stas@FreeBSD.org>
: > : > Stanislav Sedov <stas@FreeBSD.org> writes:
: > : > : -----BEGIN PGP SIGNED MESSAGE-----
: > : > : Hash: SHA1
: > : > :
: > : > : On Tue, 21 Apr 2009 09:25:05 -0600 (MDT)
: > : > : "M. Warner Losh" <imp@bsdimp.com> mentioned:
: > : > :
: > : > : > In message: <200904201547.n3KFl6Z6050834@svn.freebsd.org>
: > : > : > Stanislav Sedov <stas@freebsd.org> writes:
: > : > : > : Author: stas
: > : > : > : Date: Mon Apr 20 15:47:06 2009
: > : > : > : New Revision: 191322
: > : > : > : URL: http://svn.freebsd.org/changeset/base/191322
: > : > : > :
: > : > : > : Log:
: > : > : > : - Give a warning and start the oscillator if it was not
: > previously
: > : > : > : runned.
: > : > : > : - Rename ds1672 -> rtc to follow the other drivers.
: > : > : >
: > : > : > This is a bad change. Please back it out. There are multiple
: > : > : > different kinds of rtc clocks that can live on i2c.
: > : > : >
: > : > :
: > : > : Why do you want to? We already have ds133x under the same
: > name. In case
: > : > : if there're multiple clocks in the same systems the first one
: > will
: > : > : have the name of rtc0, the second - rtc1 and so on.
: > : >
: > : > Because you'll want to support a range of boards that might have
: > : > multiple different kinds of rtc i2c clocks. Calling them all i2c
: > : > won't work because you can't probe the i2c bus in any meaningful
: > way.
: > : > the ds133x one, if it is named rtc, is wrong too.
: > : >
: > :
: > : I still don't fully see your point. If you have two different RTCs
: > : sitting on I2C bus they either have a different address, or they're
: > : attached to different rtc busses. So you can configure them in a
: > : usual way via hints.
: >
: > You don't see my point, that's right.
: >
: > Consider one kernel. Two different boards. Different RTC chips on
: > each of these boards. Hints loaded from the boot loader. Now, on one
: > board the ds1672 is used, on the other a ds163x is used. How does the
: > right driver get attached in that case?
:
: If these boards are different, they are supposed to have different
: dedicated hints; doesn't this solve your concerns?
I don't think so. If there's two drivers named "rtc" which one gets
attached?
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090421.133736.1374096586.imp>